From: Kees Cook <kees@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-hardening@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] gcc-15: acpi: sprinkle random '__nonstring' crumbles around
Date: Mon, 21 Apr 2025 09:39:07 -0700 [thread overview]
Message-ID: <202504210909.D4EAB689@keescook> (raw)
In-Reply-To: <CAHk-=whryuuKnd_5w6169EjfRr_f+t5BRmKt+qfjALFzfKQNvQ@mail.gmail.com>
On Sun, Apr 20, 2025 at 09:33:19PM -0700, Linus Torvalds wrote:
> On Sun, 20 Apr 2025 at 18:52, Kees Cook <kees@kernel.org> wrote:
> >
> > Can you please revert this mess and use what has already been planned
> > for this warning? It is, once again, really frustrating when you update
> > to unreleased compiler versions. :(
>
> Ehh. Kees, that's the compiler in F42.
> Really. It's not some "unreleased compiler version".
> It's the main compiler in one of the biggest Linux distributions, out now.
Fine, perhaps I'm nitpicking the fact. F42 made an unreleased compiler
their default, so it is technically "released".
> Why do you think I made the change? Because the kernel DID NOT BUILD
> without those changes.
Yes, I understand that, but you didn't coordinate with anyone. You
didn't search lore for the warning strings, you didn't even check -next
where you've now created merge conflicts. You put insufficiently tested
patches into the tree at the last minute and cut an rc release that broke
for everyone using GCC <15. You mercilessly flame maintainers for much
much less.
Why make compiler version upgrades a surprise? I'm hardly the only person
who was working to make the GCC 15 transition smooth. This made more
work for people, wasted your time to recreate existing patches, and broke
the build. I am hardly being unreasonable in asking you to do better.
--
Kees Cook
next prev parent reply other threads:[~2025-04-21 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 0:35 [PATCH] gcc-15: acpi: sprinkle random '__nonstring' crumbles around Guenter Roeck
2025-04-21 1:52 ` Kees Cook
2025-04-21 4:33 ` Linus Torvalds
2025-04-21 16:39 ` Kees Cook [this message]
2025-04-21 16:50 ` Linus Torvalds
2025-04-27 11:24 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504210909.D4EAB689@keescook \
--to=kees@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox