From: Sudeep Holla <sudeep.holla@arm.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: <rafael@kernel.org>, <lenb@kernel.org>,
<linux-acpi@vger.kernel.org>, <jmeurin@google.com>,
<jeremy.linton@arm.com>, <jonathan.cameron@huawei.com>,
<zhanjie9@hisilicon.com>, <prime.zeng@hisilicon.com>,
<yangyicong@hisilicon.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH] ACPI: PPTT: Fix table length check when parsing processor nodes
Date: Wed, 7 May 2025 12:40:35 +0100 [thread overview]
Message-ID: <20250507-devout-mysterious-jackal-e50e00@sudeepholla> (raw)
In-Reply-To: <20250507035124.28071-1-yangyicong@huawei.com>
On Wed, May 07, 2025 at 11:51:24AM +0800, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> Below error is met on my board and QEMU VM on SMT or non-SMT machine:
> ACPI PPTT: PPTT table found, but unable to locate core 31 (31)
>
> This is because the processor node is found by iterating the PPTT
> table under condition (for both acpi_find_processor_node() and
> acpi_pptt_leaf_node()):
> while (entry + proc_sz < table_end)
> [parse the processor node]
>
> If the last processor node is happened to be the last node in the
> PPTT table, above condition will always be false since
> entry + proc_sz == table_end. Thus the last CPU is not parsed.
> Fix the loop condition to resolve the issue.
>
> This issue is exposed by [1] but the root cause is explained above.
> Before [1] entry + proc_sz is always smaller than table_end.
>
Another thread [1] with similar patch.
--
Regards,
Sudeep
[1] https://lore.kernel.org/all/20250506-draco-taped-15f475cd@mheyne-amazon
next prev parent reply other threads:[~2025-05-07 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 3:51 [PATCH] ACPI: PPTT: Fix table length check when parsing processor nodes Yicong Yang
2025-05-07 11:40 ` Sudeep Holla [this message]
2025-05-07 11:44 ` Rafael J. Wysocki
2025-05-07 11:47 ` Sudeep Holla
2025-05-07 11:51 ` Rafael J. Wysocki
2025-05-07 11:55 ` Sudeep Holla
2025-05-07 14:35 ` Jonathan Cameron
2025-05-07 15:35 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507-devout-mysterious-jackal-e50e00@sudeepholla \
--to=sudeep.holla@arm.com \
--cc=jeremy.linton@arm.com \
--cc=jmeurin@google.com \
--cc=jonathan.cameron@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox