Re: [PATCH] ACPI/PPTT: fix off-by-one error

Sudeep Holla
2025-05-07T15:52:19Z

On Wed, May 07, 2025 at 04:47:10PM +0100, Sudeep Holla wrote:
> On Wed, May 07, 2025 at 10:25:25AM -0500, Jeremy Linton wrote:

[...]

>
> > Otherwise the original sizeof * change isn't really fixing anything.
> >
>
> How about extending the check for entry->length ? Do you think it will
> be any better ? The entry pointer is anyway updated to jump entry->length
> ahead at the end of the loop.
>

Scratch that, we will still end up reading an invalid node at the end
if (entry + entry->length > table_end)

--
Regards,
Sudeep