From: Sudeep Holla <sudeep.holla@arm.com>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: "Heyne, Maximilian" <mheyne@amazon.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI/PPTT: fix off-by-one error
Date: Wed, 7 May 2025 16:52:14 +0100 [thread overview]
Message-ID: <20250507-strict-nifty-alligator-496cda@sudeepholla> (raw)
In-Reply-To: <20250507-tasteful-wren-of-devotion-f010af@sudeepholla>
On Wed, May 07, 2025 at 04:47:10PM +0100, Sudeep Holla wrote:
> On Wed, May 07, 2025 at 10:25:25AM -0500, Jeremy Linton wrote:
[...]
>
> > Otherwise the original sizeof * change isn't really fixing anything.
> >
>
> How about extending the check for entry->length ? Do you think it will
> be any better ? The entry pointer is anyway updated to jump entry->length
> ahead at the end of the loop.
>
Scratch that, we will still end up reading an invalid node at the end
if (entry + entry->length > table_end)
--
Regards,
Sudeep
prev parent reply other threads:[~2025-05-07 15:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 13:13 [PATCH] ACPI/PPTT: fix off-by-one error Heyne, Maximilian
2025-05-06 13:43 ` Sudeep Holla
2025-05-06 20:08 ` Heyne, Maximilian
2025-05-07 11:52 ` Sudeep Holla
2025-05-07 11:56 ` Heyne, Maximilian
2025-05-07 12:30 ` Sudeep Holla
2025-05-07 12:35 ` Rafael J. Wysocki
2025-05-07 12:42 ` Heyne, Maximilian
2025-05-07 12:50 ` Rafael J. Wysocki
2025-05-07 13:01 ` Sudeep Holla
2025-05-07 12:56 ` Sudeep Holla
2025-05-07 14:29 ` Heyne, Maximilian
2025-05-07 15:12 ` Sudeep Holla
2025-05-06 20:11 ` Jeremy Linton
2025-05-07 11:53 ` Heyne, Maximilian
2025-05-07 11:59 ` Rafael J. Wysocki
2025-05-07 12:17 ` Heyne, Maximilian
2025-05-07 15:25 ` Jeremy Linton
2025-05-07 15:42 ` Rafael J. Wysocki
2025-05-07 15:51 ` Jeremy Linton
2025-05-07 16:12 ` Rafael J. Wysocki
2025-05-07 16:28 ` Sudeep Holla
2025-05-07 16:31 ` Jeremy Linton
2025-05-07 16:38 ` Jeremy Linton
2025-05-07 16:41 ` Jeremy Linton
2025-05-07 17:01 ` Rafael J. Wysocki
2025-05-07 17:35 ` Jeremy Linton
2025-05-07 17:59 ` Jeremy Linton
2025-05-07 15:47 ` Sudeep Holla
2025-05-07 15:52 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507-strict-nifty-alligator-496cda@sudeepholla \
--to=sudeep.holla@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jeremy.linton@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mheyne@amazon.de \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox