From: Herve Codina <herve.codina@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Peter Rosin <peda@axentia.se>,
Derek Kiernan <derek.kiernan@amd.com>,
Dragan Cvetic <dragan.cvetic@amd.com>,
Arnd Bergmann <arnd@arndb.de>,
Herve Codina <herve.codina@bootlin.com>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>, Len Brown <lenb@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Wolfram Sang <wsa@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-spi@vger.kernel.org,
linux-acpi@vger.kernel.org,
Allan Nielsen <allan.nielsen@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Steen Hegelund <steen.hegelund@microchip.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [PATCH v2 02/26] driver core: Rename get_dev_from_fwnode() wrapper to get_device_from_fwnode()
Date: Wed, 7 May 2025 09:12:44 +0200 [thread overview]
Message-ID: <20250507071315.394857-3-herve.codina@bootlin.com> (raw)
In-Reply-To: <20250507071315.394857-1-herve.codina@bootlin.com>
get_dev_from_fwnode() calls get_device() and so it acquires a reference
on the device returned.
In order to be more obvious that this wrapper is a get_device() variant,
rename it to get_device_from_fwnode().
Suggested-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/lkml/CAGETcx97QjnjVR8Z5g0ndLHpK96hLd4aYSV=iEkKPNbNOccYmA@mail.gmail.com/
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Saravana Kannan <saravanak@google.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/base/core.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index d2f9d3a59d6b..f30260fd3031 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1881,7 +1881,7 @@ static void fw_devlink_unblock_consumers(struct device *dev)
device_links_write_unlock();
}
-#define get_dev_from_fwnode(fwnode) get_device((fwnode)->dev)
+#define get_device_from_fwnode(fwnode) get_device((fwnode)->dev)
static bool fwnode_init_without_drv(struct fwnode_handle *fwnode)
{
@@ -1891,7 +1891,7 @@ static bool fwnode_init_without_drv(struct fwnode_handle *fwnode)
if (!(fwnode->flags & FWNODE_FLAG_INITIALIZED))
return false;
- dev = get_dev_from_fwnode(fwnode);
+ dev = get_device_from_fwnode(fwnode);
ret = !dev || dev->links.status == DL_DEV_NO_DRIVER;
put_device(dev);
@@ -1960,7 +1960,7 @@ static struct device *fwnode_get_next_parent_dev(const struct fwnode_handle *fwn
struct device *dev;
fwnode_for_each_parent_node(fwnode, parent) {
- dev = get_dev_from_fwnode(parent);
+ dev = get_device_from_fwnode(parent);
if (dev) {
fwnode_handle_put(parent);
return dev;
@@ -2016,8 +2016,8 @@ static bool __fw_devlink_relax_cycles(struct fwnode_handle *con_handle,
goto out;
}
- sup_dev = get_dev_from_fwnode(sup_handle);
- con_dev = get_dev_from_fwnode(con_handle);
+ sup_dev = get_device_from_fwnode(sup_handle);
+ con_dev = get_device_from_fwnode(con_handle);
/*
* If sup_dev is bound to a driver and @con hasn't started binding to a
* driver, sup_dev can't be a consumer of @con. So, no need to check
@@ -2156,7 +2156,7 @@ static int fw_devlink_create_devlink(struct device *con,
if (sup_handle->flags & FWNODE_FLAG_NOT_DEVICE)
sup_dev = fwnode_get_next_parent_dev(sup_handle);
else
- sup_dev = get_dev_from_fwnode(sup_handle);
+ sup_dev = get_device_from_fwnode(sup_handle);
if (sup_dev) {
/*
@@ -2225,7 +2225,7 @@ static void __fw_devlink_link_to_consumers(struct device *dev)
bool own_link = true;
int ret;
- con_dev = get_dev_from_fwnode(link->consumer);
+ con_dev = get_device_from_fwnode(link->consumer);
/*
* If consumer device is not available yet, make a "proxy"
* SYNC_STATE_ONLY link from the consumer's parent device to
--
2.49.0
next prev parent reply other threads:[~2025-05-07 7:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 7:12 [PATCH v2 00/26] lan966x pci device: Add support for SFPs Herve Codina
2025-05-07 7:12 ` [PATCH v2 01/26] Revert "treewide: Fix probing of devices in DT overlays" Herve Codina
2025-05-07 11:28 ` Mark Brown
2025-05-07 7:12 ` Herve Codina [this message]
2025-05-07 7:12 ` [PATCH v2 03/26] of: dynamic: Fix overlayed devices not probing because of fw_devlink Herve Codina
2025-05-07 7:12 ` [PATCH v2 04/26] driver core: Avoid warning when removing a device while its supplier is unbinding Herve Codina
2025-05-07 15:15 ` Andy Shevchenko
2025-05-19 11:35 ` Herve Codina
2025-05-07 7:12 ` [PATCH v2 05/26] bus: simple-pm-bus: Populate child nodes at probe Herve Codina
2025-05-08 14:27 ` Andy Shevchenko
2025-05-19 11:58 ` Herve Codina
2025-05-19 12:06 ` Andy Shevchenko
2025-05-19 14:24 ` Herve Codina
2025-05-16 19:22 ` Rafael J. Wysocki
2025-05-19 12:46 ` Herve Codina
2025-05-07 7:12 ` [PATCH v2 06/26] driver core: fw_devlink: Introduce fw_devlink_set_device() Herve Codina
2025-05-07 15:02 ` Andy Shevchenko
2025-05-19 14:27 ` Herve Codina
2025-05-07 7:12 ` [PATCH v2 07/26] drivers: core: Use fw_devlink_set_device() Herve Codina
2025-05-07 7:12 ` [PATCH v2 08/26] pinctrl: cs42l43: " Herve Codina
2025-05-07 15:06 ` Andy Shevchenko
2025-05-07 7:12 ` [PATCH v2 09/26] cxl/test: Use device_set_node() Herve Codina
2025-05-07 15:10 ` Andy Shevchenko
2025-05-08 11:47 ` Jonathan Cameron
2025-05-07 7:12 ` [PATCH v2 10/26] cxl/test: Use fw_devlink_set_device() Herve Codina
2025-05-07 7:12 ` [PATCH v2 11/26] PCI: of: " Herve Codina
2025-05-07 7:12 ` [PATCH v2 12/26] PCI: of: Set fwnode device of newly created PCI device nodes Herve Codina
2025-05-08 18:31 ` Andy Shevchenko
2025-05-08 18:35 ` Geert Uytterhoeven
2025-05-07 7:12 ` [PATCH v2 13/26] PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node Herve Codina
2025-05-07 7:12 ` [PATCH v2 14/26] i2c: core: Introduce i2c_get_adapter_physdev() Herve Codina
2025-05-07 7:12 ` [PATCH v2 15/26] i2c: mux: Set adapter physical device Herve Codina
2025-05-07 7:12 ` [PATCH v2 16/26] i2c: mux: Create missing devlink between mux and " Herve Codina
2025-05-08 19:15 ` Andy Shevchenko
2025-05-19 14:39 ` Herve Codina
2025-05-07 7:12 ` [PATCH v2 17/26] of: property: Allow fw_devlink device-tree on x86 when PCI device-tree node creation is enabled Herve Codina
2025-05-08 19:19 ` Andy Shevchenko
2025-05-07 7:13 ` [PATCH v2 18/26] clk: lan966x: Add MCHP_LAN966X_PCI dependency Herve Codina
2025-05-07 7:13 ` [PATCH v2 19/26] i2c: busses: at91: " Herve Codina
2025-05-12 22:32 ` Andi Shyti
2025-05-07 7:13 ` [PATCH v2 20/26] misc: lan966x_pci: Fix dtso nodes ordering Herve Codina
2025-05-07 7:13 ` [PATCH v2 21/26] misc: lan966x_pci: Split dtso in dtsi/dtso Herve Codina
2025-05-07 22:14 ` Andrew Lunn
2025-05-07 7:13 ` [PATCH v2 22/26] misc: lan966x_pci: Rename lan966x_pci.dtso to lan966x_evb_lan9662_nic.dtso Herve Codina
2025-05-07 22:14 ` Andrew Lunn
2025-05-07 7:13 ` [PATCH v2 23/26] misc: lan966x_pci: Introduce board specific data Herve Codina
2025-05-07 22:24 ` Andrew Lunn
2025-05-08 7:13 ` Geert Uytterhoeven
2025-05-29 13:19 ` Rob Herring
2025-05-19 14:44 ` Herve Codina
2025-05-08 19:21 ` Andy Shevchenko
2025-05-19 15:00 ` Herve Codina
2025-05-19 15:44 ` Andy Shevchenko
2025-05-07 7:13 ` [PATCH v2 24/26] misc: lan966x_pci: Add dtsi/dtso nodes in order to support SFPs Herve Codina
2025-05-07 7:13 ` [PATCH v2 25/26] misc: lan966x_pci: Sort the drivers list in Kconfig help Herve Codina
2025-05-07 7:13 ` [PATCH v2 26/26] misc: lan966x_pci: Add drivers needed to support SFPs " Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507071315.394857-3-herve.codina@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dragan.cvetic@amd.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=horatiu.vultur@microchip.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=peda@axentia.se \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox