[PATCH v2 00/26] lan966x pci device: Add support for SFPs

Herve Codina
2025-05-07T07:13:27Z

Hi,

This series add support for SFPs ports available on the LAN966x PCI
device. In order to have the SFPs supported, additional devices are
needed such as clock controller and I2C.

As a reminder, the LAN966x PCI device driver use a device-tree overlay
to describe devices available on the PCI board. Adding support for SFPs
ports consists in adding more devices in the already existing
device-tree overlay.

With those devices added, the device-tree overlay is more complex and
some consumer/supplier relationship are needed in order to remove
devices in correct order when the LAN966x PCI driver is removed.

Those links are typically provided by fw_devlink and we faced some
issues with fw_devlink and overlays.

This series gives the big picture related to the SFPs support from
fixing issues to adding new devices. Of course, it can be split if
needed.

The first part of the series (patch 1, 2 and 3) fixes fw_devlink when it
is used with overlay. Patches 1 and 3 were previously sent by Saravana
[0]. I just rebased them on top of v6.15-rc1 and added patch 2 in order
to take into account feedback received on the series sent by Saravana.

Those modification were not sufficient in our case and so, on top of
that, patch 4 and 5 fix some more issues related to fw_devlink.

Patches 6 to 11 introduce and use fw_devlink_set_device() in already
existing code.

Patches 12 and 13 are related also to fw_devlink but specific to PCI and
the device-tree nodes created during enumeration.

Patches 14, 15 and 16 are related fw_devlink too but specific to I2C
muxes. Patches purpose is to correctly set a link between an adapter
supplier and its consumer. Indeed, an i2c mux adapter's parent is not
the i2c mux supplier but the adapter the i2c mux is connected to. Adding
a new link between the adapter supplier involved when i2c muxes are used
avoid a freeze observed during device removal.

Patch 17 adds support for fw_delink on x86. fw_devlink is needed to have
the consumer/supplier relationship between devices in order to ensure a
correct device removal order. Adding fw_devlink support for x86 has been
tried in the past but was reverted [1] because it broke some systems.
Instead of enabling fw_devlink on *all* x86 system or on *all* x86
system except on those where it leads to issue, enable it only on system
where it is needed.

Patches 18 and 19 allow to build clock and i2c controller used by the
LAN966x PCI device when the LAN966x PCI device is enabled.

Patches 20 to 23 are specific to the LAN966x. They touch the current
dtso, split it in dtsi/dtso files, rename the dtso and improve the
driver to allow easier support for other boards.

The next patch (patch 24) update the LAN966x device-tree overlay itself
to have the SPF ports and devices they depends on described.

The last two patches (patches 25 and 26) sort the existing drivers in
the needed driver list available in the Kconfig help and add new drivers
in this list keep the list up to date with the devices described in the
device-tree overlay.

Once again, this series gives the big picture and can be split if
needed. Let me know.

[0] https://lore.kernel.org/lkml/20240411235623.1260061-1-saravanak@google.com/
[1] https://lore.kernel.org/lkml/3c1f2473-92ad-bfc4-258e-a5a08ad73dd0@web.de/

Compare to previous iteration, this v2 series mainly:
- Remove unneeded 'From' tag from commit logs
- Add 'Reviewed-by' tags
- Update commit logs
- Introduce fw_devlink_set_device()
- Split the dtso in dtsi/dtso files and rename the dtso

Best regards,
Hervé

Changes: v1 -> v2
v1: https://lore.kernel.org/lkml/20250407145546.270683-1-herve.codina@bootlin.com/

- Patch 1 and 3
Remove 'From' tag from the commit log

- Patch 2
Add 'Reviewed-by: Andy Shevchenko'
Add 'Reviewed-by: Saravana Kannan'
Add 'Reviewed-by: Luca Ceresoli'

- Patch 4 and 5
No changes

- Patch 6 (new in v2)
Introduce fw_devlink_set_device()

- Patch 7 (new in v2)
Use existing device_set_node() helper.

- Patch 8 to 11 (new in v2)
Use fw_devlink_set_device() in existing code.

- Patch 12 (6 in v1)
Use fw_devlink_add_device()

- Patch 13 (7 in v1)
No changes

- Patch 14 (8 in v1)
Update commit log
Use 'physdev' instead of 'supplier'
Minor fixes in i2c_get_adapter_physdev() kdoc

- Patch 15 and 16 (9 and 10 in v1)
Use 'physdev' instead of 'supplier' (commit log, title and code)

- Patch 17 (11 in v2)
Enable fw_devlink on x86 only if PCI_DYNAMIC_OF_NODES is enabled.
Rework commit log.

- Patch 18, 19 and 20 (12, 13 and 14 in v1)
No changes

- Patch 21 (new in v2)
Split dtso in dtsi/dtso

- Patch 22 (new in v2)
Rename lan966x_pci.dtso using the specific board name

- Patch 23 (new in v2)
Improve the driver introducing board specific data to ease support
for other boards (avoid the direct dtbo reference in the function
loading the dtbo).

- Patch 24 (15 in v1)
Refactor due to dtso split in dtsi/dtso

- Patch 25 (new in v2)
Sort exist driver list in Kconfig help

- Patch 26 (16 in v1)
Keep alphanumeric order for new drivers added in Kconfig help

Herve Codina (24):
driver core: Rename get_dev_from_fwnode() wrapper to
get_device_from_fwnode()
driver core: Avoid warning when removing a device while its supplier
is unbinding
bus: simple-pm-bus: Populate child nodes at probe
driver core: fw_devlink: Introduce fw_devlink_set_device()
drivers: core: Use fw_devlink_set_device()
pinctrl: cs42l43: Use fw_devlink_set_device()
cxl/test: Use device_set_node()
cxl/test: Use fw_devlink_set_device()
PCI: of: Use fw_devlink_set_device()
PCI: of: Set fwnode device of newly created PCI device nodes
PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge
node
i2c: core: Introduce i2c_get_adapter_physdev()
i2c: mux: Set adapter physical device
i2c: mux: Create missing devlink between mux and adapter physical
device
of: property: Allow fw_devlink device-tree on x86 when PCI device-tree
node creation is enabled
clk: lan966x: Add MCHP_LAN966X_PCI dependency
i2c: busses: at91: Add MCHP_LAN966X_PCI dependency
misc: lan966x_pci: Fix dtso nodes ordering
misc: lan966x_pci: Split dtso in dtsi/dtso
misc: lan966x_pci: Rename lan966x_pci.dtso to
lan966x_evb_lan9662_nic.dtso
misc: lan966x_pci: Introduce board specific data
misc: lan966x_pci: Add dtsi/dtso nodes in order to support SFPs
misc: lan966x_pci: Sort the drivers list in Kconfig help
misc: lan966x_pci: Add drivers needed to support SFPs in Kconfig help

Saravana Kannan (2):
Revert "treewide: Fix probing of devices in DT overlays"
of: dynamic: Fix overlayed devices not probing because of fw_devlink

MAINTAINERS | 3 +-
drivers/base/core.c | 97 +++++++++---
drivers/bus/imx-weim.c | 6 -
drivers/bus/simple-pm-bus.c | 23 +--
drivers/clk/Kconfig | 2 +-
drivers/i2c/busses/Kconfig | 2 +-
drivers/i2c/i2c-core-base.c | 16 ++
drivers/i2c/i2c-core-of.c | 5 -
drivers/i2c/i2c-mux.c | 21 +++
drivers/misc/Kconfig | 11 +-
drivers/misc/Makefile | 2 +-
drivers/misc/lan966x_evb_lan9662_nic.dtso | 167 ++++++++++++++++++++
drivers/misc/lan966x_pci.c | 30 +++-
drivers/misc/lan966x_pci.dtsi | 172 +++++++++++++++++++++
drivers/misc/lan966x_pci.dtso | 177 ----------------------
drivers/of/dynamic.c | 1 -
drivers/of/overlay.c | 15 ++
drivers/of/platform.c | 5 -
drivers/of/property.c | 2 +-
drivers/pci/of.c | 10 +-
drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 2 +-
drivers/spi/spi.c | 5 -
include/linux/fwnode.h | 7 +
include/linux/i2c.h | 3 +
tools/testing/cxl/test/cxl.c | 4 +-
25 files changed, 539 insertions(+), 249 deletions(-)
create mode 100644 drivers/misc/lan966x_evb_lan9662_nic.dtso
create mode 100644 drivers/misc/lan966x_pci.dtsi
delete mode 100644 drivers/misc/lan966x_pci.dtso

--
2.49.0