From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 632CD27A128; Tue, 20 May 2025 11:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747739339; cv=none; b=hSyI6Gn8wHcFeAMiKKYi4BpyDCMQOLw5UvWpCFLaIS9WCcMXb4aaE0+KxcHpTkEpFsMnVMuKh6KRpinUv/AQzCLBW7DWJzsYbsJUHIh7zbYwRU1oYQ+ERcZyya5I4TbfqoT9g6B4/hypyl6cfx7F5kbnKsVtyk5gBETSvyNKkWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747739339; c=relaxed/simple; bh=xOSgR7Uj1iG0IGZQV8kzsDkw1k4xr5zmRTWDBRZ71fU=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YBIqLoUTpTMohvwEJg458CjCucXGMrAVLZUPVg6RySjHBlsHGFRSNv4s0AkTLSQW3wV353XVd0TORSzR7RfXja3zNh7fYiGe4leRfdrYcI9wO3O8pUAudicgmm7poq0gf4fqY7YLgO6Sp+mgp+pzvG3VAvQubuYs4M/itXZ+bwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4b1sBD4ZWFz6M4rd; Tue, 20 May 2025 19:04:04 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 77202140114; Tue, 20 May 2025 19:08:54 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 20 May 2025 13:08:53 +0200 Date: Tue, 20 May 2025 12:08:51 +0100 From: Jonathan Cameron To: "Fabio M. De Francesco" CC: "Rafael J . Wysocki" , Len Brown , Davidlohr Bueso , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Tony Luck , Borislav Petkov , , , , , , Subject: Re: [PATCH 1/4 v2] ACPI: extlog: Trace CPER Non-standard Section Body Message-ID: <20250520120851.000062cf@huawei.com> In-Reply-To: <20250429172109.3199192-2-fabio.m.de.francesco@linux.intel.com> References: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> <20250429172109.3199192-2-fabio.m.de.francesco@linux.intel.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500012.china.huawei.com (7.191.174.4) To frapeml500008.china.huawei.com (7.182.85.71) On Tue, 29 Apr 2025 19:21:06 +0200 "Fabio M. De Francesco" wrote: > ghes_do_proc() has a catch-all for unknown or unhandled CPER formats > (UEFI v2.10 Appendix N 2.3), extlog_print() does not. This gap was > noticed by a RAS test that injected CXL protocol errors which were > notified to extlog_print() via the IOMCA (I/O Machine Check > Architecture) mechanism. Bring parity to the extlog_print() path by > including a similar log_non_standard_event(). > > Cc: Dan Williams > Reviewed-by: Dan Williams > Signed-off-by: Fabio M. De Francesco Makes sense to me. Reviewed-by: Jonathan Cameron > --- > drivers/acpi/acpi_extlog.c | 6 ++++++ > drivers/ras/ras.c | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c > index f7fb7205028d..caca6ccd6e99 100644 > --- a/drivers/acpi/acpi_extlog.c > +++ b/drivers/acpi/acpi_extlog.c > @@ -182,6 +182,12 @@ static int extlog_print(struct notifier_block *nb, unsigned long val, > if (gdata->error_data_length >= sizeof(*mem)) > trace_extlog_mem_event(mem, err_seq, fru_id, fru_text, > (u8)gdata->error_severity); > + } else { > + void *err = acpi_hest_get_payload(gdata); > + > + log_non_standard_event(sec_type, fru_id, fru_text, > + gdata->error_severity, err, > + gdata->error_data_length); > } > } > > diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c > index a6e4792a1b2e..ac0e132ccc3e 100644 > --- a/drivers/ras/ras.c > +++ b/drivers/ras/ras.c > @@ -51,6 +51,7 @@ void log_non_standard_event(const guid_t *sec_type, const guid_t *fru_id, > { > trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len); > } > +EXPORT_SYMBOL_GPL(log_non_standard_event); > > void log_arm_hw_error(struct cper_sec_proc_arm *err) > {