From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>
Subject: [PATCH v1 5/5] ACPI: proc: Prefer to use octal permission
Date: Thu, 12 Jun 2025 23:11:29 +0300 [thread overview]
Message-ID: <20250612201321.3536493-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com>
Octal permissions are preferred over the symbolics ones
for readbility. This ceases warning message pointed by checkpatch.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/proc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
index 440150c67ba6..c08ead07252b 100644
--- a/drivers/acpi/proc.c
+++ b/drivers/acpi/proc.c
@@ -139,6 +139,5 @@ static const struct proc_ops acpi_system_wakeup_device_proc_ops = {
void __init acpi_sleep_proc_init(void)
{
/* 'wakeup device' [R/W] */
- proc_create("wakeup", S_IFREG | S_IRUGO | S_IWUSR,
- acpi_root_dir, &acpi_system_wakeup_device_proc_ops);
+ proc_create("wakeup", 0644, acpi_root_dir, &acpi_system_wakeup_device_proc_ops);
}
--
2.47.2
next prev parent reply other threads:[~2025-06-12 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 20:11 [PATCH v1 0/5] ACPI: proc: A few cleanups Andy Shevchenko
2025-06-12 20:11 ` [PATCH v1 1/5] ACPI: wakeup: Drop unneeded casting for sleep_state Andy Shevchenko
2025-06-12 20:11 ` [PATCH v1 2/5] ACPI: proc: Use correct format specifier and drop casting Andy Shevchenko
2025-06-12 20:11 ` [PATCH v1 3/5] ACPI: proc: Remove unused header Andy Shevchenko
2025-06-12 20:11 ` [PATCH v1 4/5] ACPI: proc: Use str_enabled_disabled() helper Andy Shevchenko
2025-06-12 20:11 ` Andy Shevchenko [this message]
2025-06-24 14:04 ` [PATCH v1 0/5] ACPI: proc: A few cleanups Andy Shevchenko
2025-06-26 19:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612201321.3536493-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).