From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13B1D1805E; Sat, 23 Aug 2025 06:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755931298; cv=none; b=I9uWhH4ueZrG8BTSXwSXKPuhrqyQJwelc94l8r4FyevS9wvVNs7eydl/KC8nyNPdbzkNc6KoliFLs1Rr5RwBAL+0v55x2K1lMWNBtjbcFM9qq39gUknrZz/oF8+aMlmqZF+GI1tpW4yH6khpKz3ss1kak45fiBTnrKt64mZ40Zs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755931298; c=relaxed/simple; bh=W2xSsVTOfKvNUrTWf8mlEmNx+BmGW/cRdE/WDxMwuCQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=esfQt+V7IBNNLZ4Ry6wjTHKcgnqQ1+gkMBFPI4JQJekWH9ssmCsbf+uxr1ZYBJqwRCZSn4oAC+xrbLpVMdZMFPHYP5dcyC5J5AVJhV2X1D2+BrVHEnMyrKWd8gWz+gy11Y6kFNXHLuxFLWrzs3fC3Zc/+JYiNYVug4LNn3cjQYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Tgjf3fhy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Tgjf3fhy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05EA8C4CEE7; Sat, 23 Aug 2025 06:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755931297; bh=W2xSsVTOfKvNUrTWf8mlEmNx+BmGW/cRdE/WDxMwuCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tgjf3fhy/95FjTkdKOoetheW/ejk9PsgRrIfYJ69pvVByfXzZF+BDHUjnaUQTFFI2 3etnY578RIuxhkTxEA9FHO4kZx8DLjXtNyKuW91mwTNcvLc/XSosyAAO8NMKMPEebd cb/ucLkpzVx2e0jIOuR3lkwh0JJ22rHLQNsd98Ww= Date: Sat, 23 Aug 2025 08:41:34 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: James Morse , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, LKML , Amit Singh Tomar , Baisheng Gao , Baolin Wang , bobo.shaobowang@huawei.com, Carl Worth , Catalin Marinas , Conor Dooley , Danilo Krummrich , Dave Martin , David Hildenbrand , Drew Fustini , D Scott Phillips , Fenghua Yu , Hanjun Guo , Jamie Iles , Jonathan Cameron , Koba Ko , Krzysztof Kozlowski , Len Brown , Linu Cherian , Lorenzo Pieralisi , Peter Newman , "Rafael J. Wysocki" , Rex Nie , Rob Herring , Rohit Mathew , Shameer Kolothum , Shanker Donthineni , Shaopeng Tan , Sudeep Holla , Will Deacon , Xin Hao Subject: Re: [PATCH 10/33] arm_mpam: Add probe/remove for mpam msc driver and kbuild boiler plate Message-ID: <2025082328-acorn-wound-5c3d@gregkh> References: <20250822153048.2287-11-james.morse@arm.com> <00053767-352d-4185-8542-687da0fb5e57@web.de> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <00053767-352d-4185-8542-687da0fb5e57@web.de> On Fri, Aug 22, 2025 at 09:55:33PM +0200, Markus Elfring wrote: > … > … > > +static int mpam_msc_drv_probe(struct platform_device *pdev) > > +{ > … > > + } while (0); > > + mutex_unlock(&mpam_list_lock); > > + > > + if (!err) { > > + /* Create RIS entries described by firmware */ > > + if (!acpi_disabled) > > + err = acpi_mpam_parse_resources(msc, plat_data); > > + else > > + err = mpam_dt_parse_resources(msc, plat_data); > > + } > > + > > + if (!err && fw_num_msc == mpam_num_msc) > > + mpam_discovery_complete(); > > + > > + if (err && msc) > > + mpam_msc_drv_remove(pdev); > > + > > + return err; > > +} > … > > * Would you like to integrate anything from the following source code variant? > > if (!err) > /* Create RIS entries described by firmware */ > err = acpi_disabled > ? mpam_dt_parse_resources(msc, plat_data) > : acpi_mpam_parse_resources(msc, plat_data); > > if (err) { > if (msc) > mpam_msc_drv_remove(pdev); > } else { > if (fw_num_msc == mpam_num_msc) > mpam_discovery_complete(); > } > > * How do you think about to increase the application of scope-based resource management > at further places? > > > Regards, > Markus Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot