From: cp0613@linux.alibaba.com
To: rafael@kernel.org
Cc: cp0613@linux.alibaba.com, guoren@kernel.org,
jeeheng.sia@starfivetech.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: SPCR: Support Precise Baud Rate filed
Date: Fri, 12 Sep 2025 20:23:49 +0800 [thread overview]
Message-ID: <20250912122349.2247-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <CAJZ5v0iZmHCOzcTD6b4XGNXWUWEoO0v_qLMDFNtA43XLAOmhZQ@mail.gmail.com>
On Fri, 12 Sep 2025 11:29:44 +0200, rafael@kernel.org wrote:
> > + if (table->precise_baudrate)
> > + baud_rate =3D table->precise_baudrate;
> > + else {>
> The outer braces here are redundant and if you combined the "else"
> above with the "switch ()" statement below in one line, the patch
> would be smaller.>
> > + switch (table->baud_rate) {
> > + case 0:
Thanks for your suggestion. I will modify it.
next prev parent reply other threads:[~2025-09-12 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 8:57 [PATCH] ACPI: SPCR: Support Precise Baud Rate filed cp0613
2025-09-12 9:29 ` Rafael J. Wysocki
2025-09-12 12:23 ` cp0613 [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-09-12 14:02 [PATCH v2] " Rafael J. Wysocki
2025-09-13 7:07 ` [PATCH] " cp0613
2025-09-13 5:24 [PATCH v2] " Guo Ren
2025-09-13 7:06 ` [PATCH] " cp0613
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912122349.2247-1-cp0613@linux.alibaba.com \
--to=cp0613@linux.alibaba.com \
--cc=guoren@kernel.org \
--cc=jeeheng.sia@starfivetech.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox