public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: cp0613@linux.alibaba.com
To: guoren@kernel.org
Cc: cp0613@linux.alibaba.com, jeeheng.sia@starfivetech.com,
	lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH] ACPI: SPCR: Support Precise Baud Rate filed
Date: Sat, 13 Sep 2025 15:06:25 +0800	[thread overview]
Message-ID: <20250913070625.16332-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <CAJF2gTTn6PhqjOPAxVfSy_8avb1_7BAeqOsFxPnvmZ3KF8sqog@mail.gmail.com>

On Sat, 13 Sep 2025 13:24:21 +0800, guoren@kernel.org wrote:

> > It contains a specific non-zero baud rate which overrides the value
> > of the Configured Baud Rate field. If this field is zero or not
> The spec states that it would "override" the baud rate. That means it
> should happen behind the table->baud_rate or firmware still needs to
> give out a legal Configured Baud Rate for precise_baudrate.> 

> Then, we move these:
> +       if (table->precise_baudrate)
> +               baud_rate = table->precise_baudrate;
> behind the "switch (table->baud_rate) {}".> 

> Right?> 

> > present, Configured Baud Rate is used.

OK, I think "override" means priority in a sense, there is no need to do
an overriding action in the behavior.

  reply	other threads:[~2025-09-13  7:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12 12:25 [PATCH v2] ACPI: SPCR: Support Precise Baud Rate filed cp0613
2025-09-12 14:02 ` Rafael J. Wysocki
2025-09-13  7:07   ` [PATCH] " cp0613
2025-09-13  5:24 ` [PATCH v2] " Guo Ren
2025-09-13  7:06   ` cp0613 [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-09-12  8:57 [PATCH] " cp0613
2025-09-12  9:29 ` Rafael J. Wysocki
2025-09-12 12:23   ` cp0613

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250913070625.16332-1-cp0613@linux.alibaba.com \
    --to=cp0613@linux.alibaba.com \
    --cc=guoren@kernel.org \
    --cc=jeeheng.sia@starfivetech.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox