From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>,
"Mika Westerberg" <westeri@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: initialize acpi_gpio_info struct
Date: Mon, 15 Sep 2025 08:46:10 +0200 [thread overview]
Message-ID: <20250915064610.GB476609@black.igk.intel.com> (raw)
In-Reply-To: <aMeyluS3KuzkTJy2@smile.fi.intel.com>
On Mon, Sep 15, 2025 at 09:30:46AM +0300, Andy Shevchenko wrote:
> On Mon, Sep 15, 2025 at 06:47:03AM +0200, Mika Westerberg wrote:
> > On Fri, Sep 12, 2025 at 10:18:50PM +0200, Sébastien Szymanski wrote:
> > > Since commit 7c010d463372 ("gpiolib: acpi: Make sure we fill struct
> > > acpi_gpio_info"), uninitialized acpi_gpio_info struct are passed to
> > > __acpi_find_gpio() and later in the call stack info->quirks is used in
> > > acpi_populate_gpio_lookup. This breaks the i2c_hid_cpi driver:
> > >
> > > [ 58.122916] i2c_hid_acpi i2c-UNIW0001:00: HID over i2c has not been provided an Int IRQ
> > > [ 58.123097] i2c_hid_acpi i2c-UNIW0001:00: probe with driver i2c_hid_acpi failed with error -22
> > >
> > > Fix this by initializing the acpi_gpio_info pass to __acpi_find_gpio()
> > >
> > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220388
> > > Fixes: 7c010d463372 ("gpiolib: acpi: Make sure we fill struct acpi_gpio_info")
> > > Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> >
> > Should have stable tag too, I think. Andy can add that once he applies.
>
> I can add, but this won't appear in the respective mailing list. Or did I miss
> a new tag for stable?
It does not need to go to the mailing list. It's enough that it is
mentioned in the commit. E.g
Cc: stable@vger.kernel.org
And the stable "machinery" will notice it once it hits the mainline.
next prev parent reply other threads:[~2025-09-15 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 20:18 [PATCH] gpiolib: acpi: initialize acpi_gpio_info struct Sébastien Szymanski
2025-09-13 0:46 ` Calvin Owens
2025-09-13 10:10 ` Hans de Goede
2025-09-15 4:47 ` Mika Westerberg
2025-09-15 6:30 ` Andy Shevchenko
2025-09-15 6:46 ` Mika Westerberg [this message]
2025-09-15 6:55 ` Andy Shevchenko
2025-09-15 15:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915064610.GB476609@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastien.szymanski@armadeus.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox