* [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
@ 2025-09-13 2:32 Shuai Xue
2025-09-15 8:35 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Shuai Xue @ 2025-09-13 2:32 UTC (permalink / raw)
To: rafael, lenb, robert.moore
Cc: andrew, bfaccini, eahariha, dan.j.williams, thorsten.blum, gourry,
xueshuai, nunodasneves, wangyuquan1236, Jonathan.Cameron,
linux-acpi, linux-kernel, acpica-devel
The Generic Initiator Affinity Structure in SRAT table uses device
handle type field to indicate the device type. According to ACPI
specification, the device handle type value of 1 represents PCI device,
not 0.
Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
---
changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
---
drivers/acpi/numa/srat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
index 53816dfab645..aa87ee1583a4 100644
--- a/drivers/acpi/numa/srat.c
+++ b/drivers/acpi/numa/srat.c
@@ -237,7 +237,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
struct acpi_srat_generic_affinity *p =
(struct acpi_srat_generic_affinity *)header;
- if (p->device_handle_type == 0) {
+ if (p->device_handle_type == 1) {
/*
* For pci devices this may be the only place they
* are assigned a proximity domain
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
2025-09-13 2:32 [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator Shuai Xue
@ 2025-09-15 8:35 ` Jonathan Cameron
2025-10-21 6:54 ` Shuai Xue
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2025-09-15 8:35 UTC (permalink / raw)
To: Shuai Xue
Cc: rafael, lenb, robert.moore, andrew, bfaccini, eahariha,
dan.j.williams, thorsten.blum, gourry, nunodasneves,
wangyuquan1236, linux-acpi, linux-kernel, acpica-devel
On Sat, 13 Sep 2025 10:32:24 +0800
Shuai Xue <xueshuai@linux.alibaba.com> wrote:
> The Generic Initiator Affinity Structure in SRAT table uses device
> handle type field to indicate the device type. According to ACPI
> specification, the device handle type value of 1 represents PCI device,
> not 0.
>
> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Thanks!
> ---
> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
> ---
> drivers/acpi/numa/srat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
> index 53816dfab645..aa87ee1583a4 100644
> --- a/drivers/acpi/numa/srat.c
> +++ b/drivers/acpi/numa/srat.c
> @@ -237,7 +237,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> struct acpi_srat_generic_affinity *p =
> (struct acpi_srat_generic_affinity *)header;
>
> - if (p->device_handle_type == 0) {
> + if (p->device_handle_type == 1) {
> /*
> * For pci devices this may be the only place they
> * are assigned a proximity domain
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
2025-09-15 8:35 ` Jonathan Cameron
@ 2025-10-21 6:54 ` Shuai Xue
2025-10-21 13:30 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Shuai Xue @ 2025-10-21 6:54 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: lenb, robert.moore, andrew, bfaccini, eahariha, dan.j.williams,
thorsten.blum, gourry, nunodasneves, wangyuquan1236, linux-acpi,
linux-kernel, acpica-devel
在 2025/9/15 16:35, Jonathan Cameron 写道:
> On Sat, 13 Sep 2025 10:32:24 +0800
> Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>
>> The Generic Initiator Affinity Structure in SRAT table uses device
>> handle type field to indicate the device type. According to ACPI
>> specification, the device handle type value of 1 represents PCI device,
>> not 0.
>>
>> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
>> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
>> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>
> Thanks!
>
>> ---
>> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
>> ---
Hi, Rafael,
Gentle ping.
Are you happy to pick this bugfix up in this cycle?
Thanks.
Shuai
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
2025-10-21 6:54 ` Shuai Xue
@ 2025-10-21 13:30 ` Rafael J. Wysocki
2025-10-21 15:06 ` Dave Jiang
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2025-10-21 13:30 UTC (permalink / raw)
To: Shuai Xue, Dave Jiang
Cc: Rafael J. Wysocki, lenb, robert.moore, andrew, bfaccini, eahariha,
dan.j.williams, thorsten.blum, gourry, nunodasneves,
wangyuquan1236, linux-acpi, linux-kernel, acpica-devel
On Tue, Oct 21, 2025 at 8:55 AM Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>
>
>
> 在 2025/9/15 16:35, Jonathan Cameron 写道:
> > On Sat, 13 Sep 2025 10:32:24 +0800
> > Shuai Xue <xueshuai@linux.alibaba.com> wrote:
> >
> >> The Generic Initiator Affinity Structure in SRAT table uses device
> >> handle type field to indicate the device type. According to ACPI
> >> specification, the device handle type value of 1 represents PCI device,
> >> not 0.
> >>
> >> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
> >> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
> >> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
> >
> > Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> >
> > Thanks!
> >
> >> ---
> >> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
> >> ---
>
>
> Hi, Rafael,
>
> Gentle ping.
>
> Are you happy to pick this bugfix up in this cycle?
drives/acpi/numa/ is maintained by Dave.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
2025-10-21 13:30 ` Rafael J. Wysocki
@ 2025-10-21 15:06 ` Dave Jiang
2025-10-22 2:08 ` Shuai Xue
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jiang @ 2025-10-21 15:06 UTC (permalink / raw)
To: Rafael J. Wysocki, Shuai Xue
Cc: lenb, robert.moore, andrew, bfaccini, eahariha, dan.j.williams,
thorsten.blum, gourry, nunodasneves, wangyuquan1236, linux-acpi,
linux-kernel, acpica-devel, linux-cxl@vger.kernel.org
On 10/21/25 6:30 AM, Rafael J. Wysocki wrote:
> On Tue, Oct 21, 2025 at 8:55 AM Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>>
>>
>>
>> 在 2025/9/15 16:35, Jonathan Cameron 写道:
>>> On Sat, 13 Sep 2025 10:32:24 +0800
>>> Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>>>
>>>> The Generic Initiator Affinity Structure in SRAT table uses device
>>>> handle type field to indicate the device type. According to ACPI
>>>> specification, the device handle type value of 1 represents PCI device,
>>>> not 0.
>>>>
>>>> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
>>>> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
>>>> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
>>>
>>> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>>>
>>> Thanks!
>>>
>>>> ---
>>>> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
>>>> ---
>>
>>
>> Hi, Rafael,
>>
>> Gentle ping.
>>
>> Are you happy to pick this bugfix up in this cycle?
>
> drives/acpi/numa/ is maintained by Dave.
Applied to cxl/fixes
7c3643f204edf1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
2025-10-21 15:06 ` Dave Jiang
@ 2025-10-22 2:08 ` Shuai Xue
0 siblings, 0 replies; 6+ messages in thread
From: Shuai Xue @ 2025-10-22 2:08 UTC (permalink / raw)
To: Dave Jiang, Rafael J. Wysocki
Cc: lenb, robert.moore, andrew, bfaccini, eahariha, dan.j.williams,
thorsten.blum, gourry, nunodasneves, wangyuquan1236, linux-acpi,
linux-kernel, acpica-devel, linux-cxl@vger.kernel.org
在 2025/10/21 23:06, Dave Jiang 写道:
>
>
> On 10/21/25 6:30 AM, Rafael J. Wysocki wrote:
>> On Tue, Oct 21, 2025 at 8:55 AM Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>>>
>>>
>>>
>>> 在 2025/9/15 16:35, Jonathan Cameron 写道:
>>>> On Sat, 13 Sep 2025 10:32:24 +0800
>>>> Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>>>>
>>>>> The Generic Initiator Affinity Structure in SRAT table uses device
>>>>> handle type field to indicate the device type. According to ACPI
>>>>> specification, the device handle type value of 1 represents PCI device,
>>>>> not 0.
>>>>>
>>>>> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
>>>>> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
>>>>> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
>>>>
>>>> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>>>>
>>>> Thanks!
>>>>
>>>>> ---
>>>>> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
>>>>> ---
>>>
>>>
>>> Hi, Rafael,
>>>
>>> Gentle ping.
>>>
>>> Are you happy to pick this bugfix up in this cycle?
>>
>> drives/acpi/numa/ is maintained by Dave.
>
> Applied to cxl/fixes
> 7c3643f204edf1
Thanks.
Shuai
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-22 2:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-13 2:32 [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator Shuai Xue
2025-09-15 8:35 ` Jonathan Cameron
2025-10-21 6:54 ` Shuai Xue
2025-10-21 13:30 ` Rafael J. Wysocki
2025-10-21 15:06 ` Dave Jiang
2025-10-22 2:08 ` Shuai Xue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox