From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 896C227E040 for ; Tue, 16 Sep 2025 04:49:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998183; cv=none; b=iAICOM2UVWus1hy1X5SUdMcYmeX8SuYUl1DTBUa1JRdGSCYGCettD35KnnEaycdaRc+p/WwbZHx+tJpn2w4LG5HR6jWeaPF/pW+gVjBQgnTb6Zl8LuvKRwz7rXfSLpIVZ91jQYQ7QD5sg7riJa/oeQTWy7+LS+Hl3bERdYI8tfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998183; c=relaxed/simple; bh=xZie7XPvdT38eYIBnvXACDOKlp4uDfFQ6p8xkwCAypA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PHuMJjxWK9ny695BvM9PdEtj+Hsp6uOiGsH9NS8IZxcgBOr0UhsO4H2xqHhwnO+DwvuLr/d5lefIlO0t3wzfHg4MnTm8Kz/i1dFrePqkFZsCnn4BiTVii+afYa6YJgWJtmOosMnkrN/tPLg8jaWjeJHZO2PDCmxn011oBSk6OBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VRPVEEEM; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VRPVEEEM" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b52047b3f19so3504791a12.2 for ; Mon, 15 Sep 2025 21:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998181; x=1758602981; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6Tcedso9pzLAwLQitmBj+2+6wC4HZyTUiqHFeMdiOi8=; b=VRPVEEEMyPFp1/apdgsdGcdVZa8RyIEDb4oi+MRkYBM99QFUqx8qesncXE5xPiXr4k 5EmQzzVM6ROAy9MD5JQWOsyeqzNpcJOOfhDFpvyiLSBzgAVmSV4PpvkG7J3oLLXh3T2t aSGMxXUkZ/sTwLMVvwCxtrd/98Mzai0cB56bcT2QDXO9wehrl8U9zH9CWY9ycecU5qrW lgZghkMXBNPhiPB0dDJ7sUurWKQUnVaHBn61VqMU8sFvJRgf6DYXbUA1UPvggaPVkZ2/ wEyAhf8NXX+w9nILAVNf9HZ/dItwjE6ImKe5EZYWjDrUvt9j68hAE0JwgxYdvG9auYLy KGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998181; x=1758602981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Tcedso9pzLAwLQitmBj+2+6wC4HZyTUiqHFeMdiOi8=; b=cdOF+hoa9YwgJPstHkscl6zf1Q3drsUbjM13kDRcK6tP68dvFhaiMauqsG95BNGaj0 KQmldkDB/MuRRFxkinPGNgppRnFjIp3frKN+OhwcbMKcO4hJqrAvtdfHGdOJ8ONXCkAE XWCgMtf2MEvcT5wyLLwBzf3TiRZ/gneD6kqjBVBjWy/t+QlaVnCEZnG/oTs8Y9HslI5P cLVzDaRp7RydtcqNR3GRzzhAxp5qSk/TlZ8UUcYBEl41zRtU6G75FDL98VyLI8vDOvfY mGg25zIuWjkd/o1mt+tyRCyXnEnRCssdksWiIu3L8ezsD0oFGuSZts648FjcpgWo9+UR 1Acg== X-Forwarded-Encrypted: i=1; AJvYcCW7FYkWKjE6DjBbCeXIPlW03zTW4oGd45C0OSrX9GRdA03a6ApFpt1YKPy5AYyTHGQ+Q8/mF+dVpiqr@vger.kernel.org X-Gm-Message-State: AOJu0Yx2c/CelRD66G8iBX7bSnXoOwvfDDr6y1TvysjZCxRiplxUCB25 nPrYaqMz0s9Rc16r2zdpQ71gryMKd9PkeCOqlB9YPPNOE0s2/wW7jshf X-Gm-Gg: ASbGncuAeiavsOJ0m5538Z2srD7O/MG5mi9sCI5C0ntQ4K898jV4MnbuqLkrSgtPKpH YpLrsdvoiGQyGWAl/K0pH4fYoFYYTPJZXwp2qoY2dLHfPblQ/QLFbbL3YiMqrDFxYbQa+Ii8bme 51Y7L5M7YyHbky4j8oYvz/grV/tfMO2CNsf+5+iOgCRPto1cNNlqdiab5/QoYIHrf5fcMShT/7L Us7+JwyOg99zvE7E36L4L3uktoAWy6Irk99hy/Dog3Kc45hLGDnl2kb4m2wxNtPB4kv5+zoO7+X W43r14gzMogs97+kj6pJzmJk4FnL2NUP6tivKfQfQP+gAyvYGL9cQ8KzOwD6jRWx9oBAXuaG9rn Yh2IMRmInbwd0VgFWeHCFZ5D19RXckYftaXihF7k= X-Google-Smtp-Source: AGHT+IEk/DXYOCMhugqpymqTGh+KMlTQeAIuikssxOXlHLYZS5SBPJrXDrKkOxyomJ+DECodEM8EoQ== X-Received: by 2002:a17:902:c40d:b0:251:a3b3:1580 with SMTP id d9443c01a7336-25d24cac4eemr191581215ad.6.1757998180587; Mon, 15 Sep 2025 21:49:40 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:49:40 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , Paolo Abeni , Jakub Kicinski , pengdonglin Subject: [PATCH v3 13/14] net: bonding: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:34 +0800 Message-Id: <20250916044735.2316171-14-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Cc: Jay Vosburgh Cc: Paolo Abeni Cc: Jakub Kicinski Signed-off-by: pengdonglin Signed-off-by: pengdonglin --- drivers/net/bonding/bond_3ad.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 4edc8e6b6b64..c53ea73f103a 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c @@ -2485,7 +2485,6 @@ void bond_3ad_state_machine_handler(struct work_struct *work) * concurrently due to incoming LACPDU as well. */ spin_lock_bh(&bond->mode_lock); - rcu_read_lock(); /* check if there are any slaves */ if (!bond_has_slaves(bond)) @@ -2537,7 +2536,6 @@ void bond_3ad_state_machine_handler(struct work_struct *work) break; } } - rcu_read_unlock(); spin_unlock_bh(&bond->mode_lock); if (update_slave_arr) -- 2.34.1