public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH 01/14] ACPI: property: Use ACPI functions in acpi_graph_get_next_endpoint() only
Date: Tue, 16 Sep 2025 19:01:16 +0300	[thread overview]
Message-ID: <20250916160129.3955410-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20250916160129.3955410-1-sakari.ailus@linux.intel.com>

Calling fwnode_get_next_child_node() in ACPI implementation of the fwnode
property API is somewhat problematic as the latter is used in the
impelementation of the former. Instead of using
fwnode_get_next_child_node() in acpi_graph_get_next_endpoint(), call
acpi_get_next_subnode() directly instead.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/acpi/property.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 436019d96027..8d9a9876748f 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -1380,7 +1380,7 @@ static struct fwnode_handle *acpi_graph_get_next_endpoint(
 
 	if (!prev) {
 		do {
-			port = fwnode_get_next_child_node(fwnode, port);
+			port = acpi_get_next_subnode(fwnode, port);
 			/*
 			 * The names of the port nodes begin with "port@"
 			 * followed by the number of the port node and they also
@@ -1398,13 +1398,13 @@ static struct fwnode_handle *acpi_graph_get_next_endpoint(
 	if (!port)
 		return NULL;
 
-	endpoint = fwnode_get_next_child_node(port, prev);
+	endpoint = acpi_get_next_subnode(port, prev);
 	while (!endpoint) {
-		port = fwnode_get_next_child_node(fwnode, port);
+		port = acpi_get_next_subnode(fwnode, port);
 		if (!port)
 			break;
 		if (is_acpi_graph_node(port, "port"))
-			endpoint = fwnode_get_next_child_node(port, NULL);
+			endpoint = acpi_get_next_subnode(port, NULL);
 	}
 
 	/*
-- 
2.47.3


  reply	other threads:[~2025-09-16 16:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 16:01 [PATCH 00/14] Align availability checks on fwnode child node enumeration Sakari Ailus
2025-09-16 16:01 ` Sakari Ailus [this message]
2025-09-17  7:17   ` [PATCH 01/14] ACPI: property: Use ACPI functions in acpi_graph_get_next_endpoint() only Andy Shevchenko
2025-09-17 11:50     ` Sakari Ailus
2025-09-16 16:01 ` [PATCH 02/14] ACPI: property: Make acpi_get_next_subnode() static Sakari Ailus
2025-09-17  7:18   ` Andy Shevchenko
2025-09-16 16:01 ` [PATCH 03/14] ACPI: property: Return present device nodes only on fwnode interface Sakari Ailus
2025-09-17  7:58   ` Andy Shevchenko
2025-09-16 16:01 ` [PATCH 04/14] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_by_id() Sakari Ailus
2025-09-17  8:39   ` Andy Shevchenko
2025-09-17 12:19     ` Sakari Ailus
2025-09-16 16:01 ` [PATCH 05/14] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_count() Sakari Ailus
2025-09-18 19:23   ` Andy Shevchenko
2025-09-16 16:01 ` [PATCH 06/14] property: Document that fwnode API returns available nodes Sakari Ailus
2025-09-22  8:03   ` Andy Shevchenko
2025-09-16 16:01 ` [PATCH 07/14] driver core: Use fwnode_for_each_child_node() instead Sakari Ailus
2025-09-23  5:43   ` Andy Shevchenko
2025-09-16 16:01 ` [PATCH 08/14] net: lan966x: " Sakari Ailus
2025-09-16 16:01 ` [PATCH 09/14] Input: touch-overlay - " Sakari Ailus
2025-09-16 16:01 ` [PATCH 10/14] media: thp7312: " Sakari Ailus
2025-09-16 16:01 ` [PATCH 11/14] leds: " Sakari Ailus
2025-09-16 16:01 ` [PATCH 12/14] leds: Use fwnode_get_next_child_node() instead Sakari Ailus
2025-09-23  5:46   ` Andy Shevchenko
2025-09-23  8:29     ` Sakari Ailus
2025-09-16 16:01 ` [PATCH 13/14] property: Drop functions operating on "available" child nodes Sakari Ailus
2025-09-16 16:01 ` [PATCH 14/14] spi: cadence: Remove explicit device node availability check Sakari Ailus
2025-09-17  7:07 ` [PATCH 00/14] Align availability checks on fwnode child node enumeration Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916160129.3955410-2-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dakr@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox