public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH 03/14] ACPI: property: Return present device nodes only on fwnode interface
Date: Tue, 16 Sep 2025 19:01:18 +0300	[thread overview]
Message-ID: <20250916160129.3955410-4-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20250916160129.3955410-1-sakari.ailus@linux.intel.com>

fwnode_graph_get_next_subnode() may return fwnode backed by ACPI device
nodes and there has been no check these devices are present in the system,
unlike there has been on fwnode OF backend. In order to provide consistent
behaviour towards callers, add a check for device presence by introducing
a new function acpi_get_next_present_subnode(), used as the
get_next_child_node() fwnode operation that also checks device node
presence.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/acpi/property.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 3e85900080ac..f7461592b5f6 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -1319,6 +1319,25 @@ acpi_get_next_subnode(const struct fwnode_handle *fwnode,
 	return NULL;
 }
 
+/**
+ * acpi_get_next_present_subnode - Return the next present child node handle for a fwnode
+ * @fwnode: Firmware node to find the next child node for.
+ * @child: Handle to one of the device's child nodes or a null handle.
+ * Like acpi_get_next_subnode, but the device nodes returned by
+ * acpi_get_next_present_subnode() are guaranteed to be present.
+ */
+static struct fwnode_handle *
+acpi_get_next_present_subnode(const struct fwnode_handle *fwnode,
+			      struct fwnode_handle *child)
+{
+	do {
+		child = acpi_get_next_subnode(fwnode, child);
+	} while (is_acpi_device_node(child) &&
+		 !acpi_device_is_present(to_acpi_device_node(child)));
+
+	return child;
+}
+
 /**
  * acpi_node_get_parent - Return parent fwnode of this fwnode
  * @fwnode: Firmware node whose parent to get
@@ -1663,7 +1682,7 @@ static int acpi_fwnode_irq_get(const struct fwnode_handle *fwnode,
 		.property_read_string_array =				\
 			acpi_fwnode_property_read_string_array,		\
 		.get_parent = acpi_node_get_parent,			\
-		.get_next_child_node = acpi_get_next_subnode,		\
+		.get_next_child_node = acpi_get_next_present_subnode,	\
 		.get_named_child_node = acpi_fwnode_get_named_child_node, \
 		.get_name = acpi_fwnode_get_name,			\
 		.get_name_prefix = acpi_fwnode_get_name_prefix,		\
-- 
2.47.3


  parent reply	other threads:[~2025-09-16 16:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 16:01 [PATCH 00/14] Align availability checks on fwnode child node enumeration Sakari Ailus
2025-09-16 16:01 ` [PATCH 01/14] ACPI: property: Use ACPI functions in acpi_graph_get_next_endpoint() only Sakari Ailus
2025-09-17  7:17   ` Andy Shevchenko
2025-09-17 11:50     ` Sakari Ailus
2025-09-16 16:01 ` [PATCH 02/14] ACPI: property: Make acpi_get_next_subnode() static Sakari Ailus
2025-09-17  7:18   ` Andy Shevchenko
2025-09-16 16:01 ` Sakari Ailus [this message]
2025-09-17  7:58   ` [PATCH 03/14] ACPI: property: Return present device nodes only on fwnode interface Andy Shevchenko
2025-09-16 16:01 ` [PATCH 04/14] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_by_id() Sakari Ailus
2025-09-17  8:39   ` Andy Shevchenko
2025-09-17 12:19     ` Sakari Ailus
2025-09-16 16:01 ` [PATCH 05/14] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_count() Sakari Ailus
2025-09-18 19:23   ` Andy Shevchenko
2025-09-16 16:01 ` [PATCH 06/14] property: Document that fwnode API returns available nodes Sakari Ailus
2025-09-22  8:03   ` Andy Shevchenko
2025-09-16 16:01 ` [PATCH 07/14] driver core: Use fwnode_for_each_child_node() instead Sakari Ailus
2025-09-23  5:43   ` Andy Shevchenko
2025-09-16 16:01 ` [PATCH 08/14] net: lan966x: " Sakari Ailus
2025-09-16 16:01 ` [PATCH 09/14] Input: touch-overlay - " Sakari Ailus
2025-09-16 16:01 ` [PATCH 10/14] media: thp7312: " Sakari Ailus
2025-09-16 16:01 ` [PATCH 11/14] leds: " Sakari Ailus
2025-09-16 16:01 ` [PATCH 12/14] leds: Use fwnode_get_next_child_node() instead Sakari Ailus
2025-09-23  5:46   ` Andy Shevchenko
2025-09-23  8:29     ` Sakari Ailus
2025-09-16 16:01 ` [PATCH 13/14] property: Drop functions operating on "available" child nodes Sakari Ailus
2025-09-16 16:01 ` [PATCH 14/14] spi: cadence: Remove explicit device node availability check Sakari Ailus
2025-09-17  7:07 ` [PATCH 00/14] Align availability checks on fwnode child node enumeration Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916160129.3955410-4-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dakr@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox