public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Slawomir Rosek <srosek@google.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
	Alex Hung <alexhung@gmail.com>,  Hans de Goede <hansg@kernel.org>,
	Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>,
	 AceLan Kao <acelan.kao@canonical.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Zhang Rui <rui.zhang@intel.com>,
	 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Tomasz Nowicki <tnowicki@google.com>,
	 Stanislaw Kardach <skardach@google.com>,
	Michal Krawczyk <mikrawczyk@google.com>,
	 linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	 platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org,
	 Slawomir Rosek <srosek@google.com>
Subject: [PATCH v2 1/6] ACPI: DPTF: Ignore SoC DTS thermal while scanning
Date: Wed, 17 Sep 2025 12:07:14 +0000	[thread overview]
Message-ID: <20250917120719.2390847-2-srosek@google.com> (raw)
In-Reply-To: <20250917120719.2390847-1-srosek@google.com>

The Intel SoC DTS thermal driver on Baytrail platform uses IRQ 86 for
critical overheating notification. The IRQ 86 is described in the _CRS
control method of INT3401 device, thus Intel SoC DTS thermal driver
requires INT3401 device to be enumerated.

Since dependency on INT3401 device is unrelated to DPTF the IS_ENABLE()
macro is removed from ACPI DPTF INT340X scan handler, instead Kconfig
is updated to ensure proper enumeration of INT3401 device.

Fixes: 014d9d5d0cc1 ("ACPI/int340x_thermal: enumerate INT3401 for Intel SoC DTS thermal driver")
Signed-off-by: Slawomir Rosek <srosek@google.com>
---
 drivers/acpi/dptf/int340x_thermal.c | 7 +------
 drivers/thermal/intel/Kconfig       | 1 +
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/acpi/dptf/int340x_thermal.c b/drivers/acpi/dptf/int340x_thermal.c
index a222df059a16..947fe50c2ef6 100644
--- a/drivers/acpi/dptf/int340x_thermal.c
+++ b/drivers/acpi/dptf/int340x_thermal.c
@@ -11,10 +11,9 @@
 
 #include "../internal.h"
 
-#define INT3401_DEVICE 0X01
 static const struct acpi_device_id int340x_thermal_device_ids[] = {
 	{"INT3400"},
-	{"INT3401", INT3401_DEVICE},
+	{"INT3401"},
 	{"INT3402"},
 	{"INT3403"},
 	{"INT3404"},
@@ -76,10 +75,6 @@ static int int340x_thermal_handler_attach(struct acpi_device *adev,
 {
 	if (IS_ENABLED(CONFIG_INT340X_THERMAL))
 		acpi_create_platform_device(adev, NULL);
-	/* Intel SoC DTS thermal driver needs INT3401 to set IRQ descriptor */
-	else if (IS_ENABLED(CONFIG_INTEL_SOC_DTS_THERMAL) &&
-		 id->driver_data == INT3401_DEVICE)
-		acpi_create_platform_device(adev, NULL);
 	return 1;
 }
 
diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
index e0268fac7093..47950859b790 100644
--- a/drivers/thermal/intel/Kconfig
+++ b/drivers/thermal/intel/Kconfig
@@ -45,6 +45,7 @@ config INTEL_SOC_DTS_IOSF_CORE
 config INTEL_SOC_DTS_THERMAL
 	tristate "Intel SoCs DTS thermal driver"
 	depends on X86 && PCI && ACPI
+	select INT340X_THERMAL
 	select INTEL_SOC_DTS_IOSF_CORE
 	help
 	  Enable this to register Intel SoCs (e.g. Bay Trail) platform digital
-- 
2.51.0.384.g4c02a37b29-goog


  reply	other threads:[~2025-09-17 12:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 12:07 [PATCH v2 0/6] ACPI: DPTF: Move INT340X enumeration from DPTF core to thermal drivers Slawomir Rosek
2025-09-17 12:07 ` Slawomir Rosek [this message]
2025-09-18  5:49   ` [PATCH v2 1/6] ACPI: DPTF: Ignore SoC DTS thermal while scanning kernel test robot
2025-09-23 12:16   ` Sławomir Rosek
2025-10-01 19:33     ` Rafael J. Wysocki
2025-09-17 12:07 ` [PATCH v2 2/6] ACPI: DPTF: Move INT340X device IDs to header Slawomir Rosek
2025-09-17 12:07 ` [PATCH v2 3/6] ACPI: DPTF: Move PCH FIVR " Slawomir Rosek
2025-09-17 12:07 ` [PATCH v2 4/6] ACPI: DPTF: Remove not supported INT340X IDs Slawomir Rosek
2025-09-17 12:07 ` [PATCH v2 5/6] ACPI: platform: Add macro for acpi platform driver Slawomir Rosek
2025-09-17 12:07 ` [PATCH v2 6/6] ACPI: DPTF: Move INT340X enumeration to modules Slawomir Rosek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917120719.2390847-2-srosek@google.com \
    --to=srosek@google.com \
    --cc=acelan.kao@canonical.com \
    --cc=alexhung@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mikrawczyk@google.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=skardach@google.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tnowicki@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox