From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@linaro.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: [PATCH v3 26/26] perf: arm_pmu: Kill last use of per-CPU cpu_armpmu pointer
Date: Mon, 22 Sep 2025 09:28:33 +0100 [thread overview]
Message-ID: <20250922082833.2038905-27-maz@kernel.org> (raw)
In-Reply-To: <20250922082833.2038905-1-maz@kernel.org>
Having removed the use of the cpu_armpmu per-CPU variable from the
interrupt handling, the only user left is the BRBE scheduler hook.
It is easy to drop the use of this variable by following the pointer
to the generic PMU structure, and get the arm_pmu structure from there.
Perform the conversion and kill cpu_armpmu altogether.
Suggested-by: Will Deacon <will@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
drivers/perf/arm_pmu.c | 5 -----
drivers/perf/arm_pmuv3.c | 2 +-
include/linux/perf/arm_pmu.h | 2 --
3 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index 959ceb3d1f556..f7abd13339630 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -104,7 +104,6 @@ static const struct pmu_irq_ops percpu_pmunmi_ops = {
.free_pmuirq = armpmu_free_percpu_pmunmi
};
-DEFINE_PER_CPU(struct arm_pmu *, cpu_armpmu);
static DEFINE_PER_CPU(int, cpu_irq);
static DEFINE_PER_CPU(const struct pmu_irq_ops *, cpu_irq_ops);
@@ -725,8 +724,6 @@ static int arm_perf_starting_cpu(unsigned int cpu, struct hlist_node *node)
if (pmu->reset)
pmu->reset(pmu);
- per_cpu(cpu_armpmu, cpu) = pmu;
-
irq = armpmu_get_cpu_irq(pmu, cpu);
if (irq)
per_cpu(cpu_irq_ops, cpu)->enable_pmuirq(irq);
@@ -746,8 +743,6 @@ static int arm_perf_teardown_cpu(unsigned int cpu, struct hlist_node *node)
if (irq)
per_cpu(cpu_irq_ops, cpu)->disable_pmuirq(irq);
- per_cpu(cpu_armpmu, cpu) = NULL;
-
return 0;
}
diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c
index f6d7bab5d555c..2dee2d928aaef 100644
--- a/drivers/perf/arm_pmuv3.c
+++ b/drivers/perf/arm_pmuv3.c
@@ -1039,7 +1039,7 @@ static int armv8pmu_user_event_idx(struct perf_event *event)
static void armv8pmu_sched_task(struct perf_event_pmu_context *pmu_ctx,
struct task_struct *task, bool sched_in)
{
- struct arm_pmu *armpmu = *this_cpu_ptr(&cpu_armpmu);
+ struct arm_pmu *armpmu = to_arm_pmu(pmu_ctx->pmu);
struct pmu_hw_events *hw_events = this_cpu_ptr(armpmu->hw_events);
if (!hw_events->branch_users)
diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h
index 6690bd77aa4ee..bab26a7d79f4c 100644
--- a/include/linux/perf/arm_pmu.h
+++ b/include/linux/perf/arm_pmu.h
@@ -132,8 +132,6 @@ struct arm_pmu {
#define to_arm_pmu(p) (container_of(p, struct arm_pmu, pmu))
-DECLARE_PER_CPU(struct arm_pmu *, cpu_armpmu);
-
u64 armpmu_event_update(struct perf_event *event);
int armpmu_event_set_period(struct perf_event *event);
--
2.47.3
next prev parent reply other threads:[~2025-09-22 8:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 8:28 [PATCH v3 00/26] genirq: Add support for percpu_devid IRQ affinity Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 01/26] irqdomain: Add firmware info reporting interface Marc Zyngier
2025-10-09 16:42 ` Jonathan Cameron
2025-09-22 8:28 ` [PATCH v3 02/26] ACPI: irq: Add IRQ affinity " Marc Zyngier
2025-09-22 17:10 ` Rafael J. Wysocki
2025-10-09 16:47 ` Jonathan Cameron
2025-09-22 8:28 ` [PATCH v3 03/26] of/irq: " Marc Zyngier
2025-10-09 16:49 ` Jonathan Cameron
2025-10-20 10:47 ` Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 04/26] platform: Add firmware-agnostic irq and affinity retrieval interface Marc Zyngier
2025-10-09 17:03 ` Jonathan Cameron
2025-10-20 10:44 ` Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 05/26] irqchip/gic-v3: Add FW info retrieval support Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 06/26] irqchip/apple-aic: " Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 07/26] coresight: trbe: Convert to new IRQ affinity retrieval API Marc Zyngier
2025-09-23 11:17 ` Suzuki K Poulose
2025-09-22 8:28 ` [PATCH v3 08/26] perf: arm_pmu: " Marc Zyngier
2025-10-10 3:39 ` Jinjie Ruan
2025-09-22 8:28 ` [PATCH v3 09/26] perf: arm_spe_pmu: " Marc Zyngier
2025-10-10 3:41 ` Jinjie Ruan
2025-09-22 8:28 ` [PATCH v3 10/26] irqchip/gic-v3: Switch high priority PPIs over to handle_percpu_devid_irq() Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 11/26] genirq: Kill handle_percpu_devid_fasteoi_nmi() Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 12/26] genirq: Merge irqaction::{dev_id,percpu_dev_id} Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 13/26] genirq: Factor-in percpu irqaction creation Marc Zyngier
2025-10-10 3:59 ` Jinjie Ruan
2025-10-10 9:28 ` Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 14/26] genirq: Add affinity to percpu_devid interrupt requests Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 15/26] genirq: Update request_percpu_nmi() to take an affinity Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 16/26] genirq: Allow per-cpu interrupt sharing for non-overlapping affinities Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 17/26] genirq: Add request_percpu_irq_affinity() helper Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 18/26] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 19/26] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 20/26] coresight: trbe: " Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 21/26] irqchip/gic-v3: Drop support for custom PPI partitions Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 22/26] irqchip/apple-aic: Drop support for custom PMU irq partitions Marc Zyngier
2025-09-22 18:43 ` Sven Peter
2025-09-22 20:24 ` Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 23/26] irqchip: Kill irq-partition-percpu Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 24/26] genirq: Kill irq_{g,s}et_percpu_devid_partition() Marc Zyngier
2025-09-22 8:28 ` [PATCH v3 25/26] irqdomain: Kill of_node_to_fwnode() helper Marc Zyngier
2025-09-22 8:28 ` Marc Zyngier [this message]
2025-09-23 10:00 ` [PATCH v3 00/26] genirq: Add support for percpu_devid IRQ affinity Will Deacon
2025-09-23 10:09 ` Marc Zyngier
2025-09-26 10:38 ` Alexandru Elisei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922082833.2038905-27-maz@kernel.org \
--to=maz@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=james.clark@linaro.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=suzuki.poulose@arm.com \
--cc=sven@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).