From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A9A01E520E; Wed, 24 Sep 2025 09:50:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758707409; cv=none; b=bmDeUkenwNZ13xBXNeeY2h33oRWndMscJos/vNjFercNvGscPOKj+wFL30MU40u1lBZtottw+JXnzywfn1QXi9C9CSQdYfGZeKuYr8e4l7euFp8GOSZb5hbmaL7koNyMKwkbDD0RdgX53zj3ogjRYnTG+5BYVfwf8lrrOsqaWXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758707409; c=relaxed/simple; bh=gJerpXj0KLCqoc3TSd07lfdCJ1BVxnT2y+/4b87yGQo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h6fXESpndBzhreKFFzkZ9LSwfnSBkAKlyoD8+mcbtVHbssBR1zj67sMrmIL6ZGwATiyibgviVurfQGQcXYzHoVtacFpcOfjtdxVD2AeEBsmCAA+GiLhp+pwaTj6/xcnt0izQhj/rcimQLgqP8aATX0AHh9xyU2AYRfQHs8z4CUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=PmGqtCHB; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PmGqtCHB" Received: from pendragon.ideasonboard.com (85-76-33-231-nat.elisa-mobile.fi [85.76.33.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 71E9D1E30; Wed, 24 Sep 2025 11:48:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1758707314; bh=gJerpXj0KLCqoc3TSd07lfdCJ1BVxnT2y+/4b87yGQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PmGqtCHBASN0EYpFpatbqfB8rlagLdZdqYBIkdlB9//oYtEm41IbCEZ3fv9gwdOSX hSBYmlGqEG/UCQ4qNdwXFjCaYGHhRQ4qlUASHcqTcrUFy8Rn+YTKk2iLJK8c8d/CoY dCXcEw7w7r3BLLmF3kO1N+h2LZTilulNOYe/6dEM= Date: Wed, 24 Sep 2025 12:49:25 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-spi@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Javier Carrasco , Dmitry Torokhov , Lee Jones , Pavel Machek , Matthias Fend , Chanwoo Choi , Krzysztof Kozlowski , Paul Elder , Mauro Carvalho Chehab , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mark Brown , Thomas Gleixner , Ingo Molnar , Jonathan Cameron Subject: Re: [PATCH v2 01/16] ACPI: property: Make acpi_get_next_subnode() static Message-ID: <20250924094925.GA8124@pendragon.ideasonboard.com> References: <20250924074602.266292-1-sakari.ailus@linux.intel.com> <20250924074602.266292-2-sakari.ailus@linux.intel.com> <20250924092750.GA28073@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250924092750.GA28073@pendragon.ideasonboard.com> On Wed, Sep 24, 2025 at 12:27:53PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Wed, Sep 24, 2025 at 10:45:47AM +0300, Sakari Ailus wrote: > > acpi_get_next_subnode() is only used in drivers/acpi/property.c. Remove > > its prototype from include/linux/acpi.h and make it static. > > > > Signed-off-by: Sakari Ailus > > Reviewed-by: Andy Shevchenko > > Reviewed-by: Laurent Pinchart > > > --- > > drivers/acpi/property.c | 5 +++-- > > include/linux/acpi.h | 10 ---------- > > 2 files changed, 3 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c > > index 436019d96027..5435628c67e7 100644 > > --- a/drivers/acpi/property.c > > +++ b/drivers/acpi/property.c > > @@ -1264,8 +1264,9 @@ static int stop_on_next(struct acpi_device *adev, void *data) > > * @fwnode: Firmware node to find the next child node for. > > * @child: Handle to one of the device's child nodes or a null handle. > > */ I missed this, I'd turn /** into /* here as the function is now static. > > -struct fwnode_handle *acpi_get_next_subnode(const struct fwnode_handle *fwnode, > > - struct fwnode_handle *child) > > +static struct fwnode_handle * > > +acpi_get_next_subnode(const struct fwnode_handle *fwnode, > > + struct fwnode_handle *child) > > { > > struct acpi_device *adev = to_acpi_device_node(fwnode); > > > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > > index 5ff5d99f6ead..703323b9fe0c 100644 > > --- a/include/linux/acpi.h > > +++ b/include/linux/acpi.h > > @@ -1349,9 +1349,6 @@ acpi_data_add_props(struct acpi_device_data *data, const guid_t *guid, > > int acpi_node_prop_get(const struct fwnode_handle *fwnode, const char *propname, > > void **valptr); > > > > -struct fwnode_handle *acpi_get_next_subnode(const struct fwnode_handle *fwnode, > > - struct fwnode_handle *child); > > - > > struct acpi_probe_entry; > > typedef bool (*acpi_probe_entry_validate_subtbl)(struct acpi_subtable_header *, > > struct acpi_probe_entry *); > > @@ -1450,13 +1447,6 @@ static inline int acpi_node_prop_get(const struct fwnode_handle *fwnode, > > return -ENXIO; > > } > > > > -static inline struct fwnode_handle * > > -acpi_get_next_subnode(const struct fwnode_handle *fwnode, > > - struct fwnode_handle *child) > > -{ > > - return NULL; > > -} > > - > > static inline struct fwnode_handle * > > acpi_graph_get_next_endpoint(const struct fwnode_handle *fwnode, > > struct fwnode_handle *prev) -- Regards, Laurent Pinchart