[PATCH] ACPI / DPTF: Use ACPI_FREE() for ACPI buffer deallocation

[PATCH] ACPI / DPTF: Use ACPI_FREE() for ACPI buffer deallocation

[Kaushlendra Kumar]

Replace kfree() with ACPI_FREE() in pch_fivr_read() for deallocating
ACPI buffer objects. The buffer.pointer contains an ACPI object allocated
through ACPI subsystem functions and should be freed using ACPI_FREE()
to ensure proper cleanup and maintain consistency with ACPI memory
management conventions.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
---
 drivers/acpi/dptf/dptf_pch_fivr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/dptf/dptf_pch_fivr.c b/drivers/acpi/dptf/dptf_pch_fivr.c
index 952216c67d58..8d7e555929d3 100644
--- a/drivers/acpi/dptf/dptf_pch_fivr.c
+++ b/drivers/acpi/dptf/dptf_pch_fivr.c
@@ -41,7 +41,7 @@ static int pch_fivr_read(acpi_handle handle, char *method, struct pch_fivr_resp
 	ret = 0;
 
 release_buffer:
-	kfree(buffer.pointer);
+	ACPI_FREE(buffer.pointer);
 	return ret;
 }
 
-- 
2.34.1

Re: [PATCH] ACPI / DPTF: Use ACPI_FREE() for ACPI buffer deallocation

[Rafael J. Wysocki]

On Mon, Oct 6, 2025 at 6:55 AM Kaushlendra Kumar
<kaushlendra.kumar@intel.com> wrote:
>
> Replace kfree() with ACPI_FREE() in pch_fivr_read() for deallocating
> ACPI buffer objects. The buffer.pointer contains an ACPI object allocated
> through ACPI subsystem functions and should be freed using ACPI_FREE()
> to ensure proper cleanup and maintain consistency with ACPI memory
> management conventions.

This is just a conventional thing because ACPI_FREE() in Linux is
implemented as kfree().

There is no correctness issue here, just the convention is not
followed, so please update the changelog.

> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
> ---
>  drivers/acpi/dptf/dptf_pch_fivr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/dptf/dptf_pch_fivr.c b/drivers/acpi/dptf/dptf_pch_fivr.c
> index 952216c67d58..8d7e555929d3 100644
> --- a/drivers/acpi/dptf/dptf_pch_fivr.c
> +++ b/drivers/acpi/dptf/dptf_pch_fivr.c
> @@ -41,7 +41,7 @@ static int pch_fivr_read(acpi_handle handle, char *method, struct pch_fivr_resp
>         ret = 0;
>
>  release_buffer:
> -       kfree(buffer.pointer);
> +       ACPI_FREE(buffer.pointer);
>         return ret;
>  }
>
> --
> 2.34.1
>

RE: [PATCH] ACPI / DPTF: Use ACPI_FREE() for ACPI buffer deallocation

[Kumar, Kaushlendra]

> This is just a conventional thing because ACPI_FREE() in Linux is implemented as kfree().
> 
> There is no correctness issue here, just the convention is not followed, so please update the changelog.

You're right. I have update the changelog in V2 patch to clarify this is about 
following ACPI coding conventions rather than fixing a functional issue.

Thanks for the feedback!

Kaushlendra