From: Badal Nilawar <badal.nilawar@intel.com>
To: intel-xe@lists.freedesktop.org, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org
Cc: anshuman.gupta@intel.com, rafael@kernel.org, lenb@kernel.org,
bhelgaas@google.com, ilpo.jarvinen@linux.intel.com,
lucas.demarchi@intel.com, rodrigo.vivi@intel.com,
varun.gupta@intel.com, ville.syrjala@linux.intel.com,
uma.shankar@intel.com, karthik.poosa@intel.com
Subject: [PATCH v5 01/12] PCI/ACPI: Add D3cold Aux Power Limit_DSM method
Date: Wed, 15 Oct 2025 13:36:59 +0530 [thread overview]
Message-ID: <20251015080710.1468409-2-badal.nilawar@intel.com> (raw)
In-Reply-To: <20251015080710.1468409-1-badal.nilawar@intel.com>
From: Anshuman Gupta <anshuman.gupta@intel.com>
Implement _DSM method 0Ah, as per PCI Firmware r3.3, sec 4.6.10,
to request auxiliary power required by the device when in D3cold state.
Note that this implementation assumes only a single device below the
Downstream Port will request for Aux Power Limit under a given
Root Port/Downstream Port because it does not track and aggregate
requests from all child devices below the Downstream Port as required
by PCI Firmware r3.3, sec 4.6.10.
Co-developed-by: Badal Nilawar <badal.nilawar@intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
V2(Bjorn/Rafael):
- Call acpi_dsm_check() to find method 0Ah supported
- Return retry interval to caller
V3(Kuppuswamy)
- Add NULL check for retry interval
V4
- Define enums for aux power request status (Rafael)
- Add Co-developed-by and clean up Signed-off-by (Kappuswamy)
(Bjorn)
- Instead of root pci device pass the pci device of driver, traverse
up the tree and discover _DSM
- Allow only function 0 of device to request aux power
- Allow retry_interval to be NULL
- Refine commit message and function description
---
drivers/pci/pci-acpi.c | 114 +++++++++++++++++++++++++++++++++++++++
include/linux/pci-acpi.h | 9 ++++
2 files changed, 123 insertions(+)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 9369377725fa..c7eab1e75dd5 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -1418,6 +1418,120 @@ static void pci_acpi_optimize_delay(struct pci_dev *pdev,
ACPI_FREE(obj);
}
+static struct pci_dev *pci_acpi_check_dsm(struct pci_dev *dev, u64 rev, u64 funcs)
+{
+ struct pci_dev *bdev;
+ acpi_handle handle;
+
+ if (!dev)
+ return ERR_PTR(-EINVAL);
+
+ bdev = dev;
+ while (bdev) {
+ handle = ACPI_HANDLE(&bdev->dev);
+ if (handle && acpi_check_dsm(handle, &pci_acpi_dsm_guid, rev, 1 << funcs))
+ return bdev;
+
+ bdev = pci_upstream_bridge(bdev);
+ }
+
+ return ERR_PTR(-ENODEV);
+}
+
+enum aux_pwr_req_status {
+ AUX_PWR_REQ_DENIED = 0x0,
+ AUX_PWR_REQ_GRANTED = 0x1,
+ AUX_PWR_REQ_NO_MAIN_PWR_REMOVAL = 0x2,
+ AUX_PWR_REQ_RETRY_INTERVAL_MIN = 0x11,
+ AUX_PWR_REQ_RETRY_INTERVAL_MAX = 0x1F
+};
+
+/**
+ * pci_acpi_request_d3cold_aux_power - Request aux power while device is in D3cold
+ * @dev: PCI device instance
+ * @requested_mw: Requested auxiliary power in milliwatts
+ * @retry_interval: Retry interval returned by platform to retry auxiliary
+ * power request
+ *
+ * Request auxilary power to platform firmware, via Root Port/Switch Downstream
+ * Port ACPI _DSM Function 0Ah, needed for the PCI device when it is in D3cold.
+ * Evaluate the _DSM and handle the response accordingly.
+ *
+ * For Multi-Function Devices, driver for Function 0 is required to report an
+ * aggregate power requirement covering all functions contained within the
+ * device.
+ *
+ * Note: Aggregation across multiple child devices beneath the Root/Switch Downstream
+ * Port is not supported.
+ *
+ * Return: Returns 0 on success and errno on failure.
+ */
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_mw,
+ u32 *retry_interval)
+{
+ union acpi_object in_obj = {
+ .integer.type = ACPI_TYPE_INTEGER,
+ .integer.value = requested_mw,
+ };
+
+ union acpi_object *out_obj;
+ int result, ret = -EINVAL;
+ struct pci_dev *bdev;
+
+ if (!dev || PCI_FUNC(dev->devfn) != 0)
+ return -EINVAL;
+
+ bdev = pci_acpi_check_dsm(dev, 4, 1 << DSM_PCI_D3COLD_AUX_POWER_LIMIT);
+
+ if (IS_ERR(bdev))
+ return PTR_ERR(bdev);
+
+ out_obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(&bdev->dev),
+ &pci_acpi_dsm_guid, 4,
+ DSM_PCI_D3COLD_AUX_POWER_LIMIT,
+ &in_obj, ACPI_TYPE_INTEGER);
+ if (!out_obj)
+ return -EINVAL;
+
+ result = out_obj->integer.value;
+ if (retry_interval)
+ *retry_interval = 0;
+
+ switch (result) {
+ case AUX_PWR_REQ_DENIED:
+ pci_dbg(bdev, "D3cold Aux Power %u mW request denied\n",
+ requested_mw);
+ break;
+ case AUX_PWR_REQ_GRANTED:
+ pci_info(bdev, "D3cold Aux Power request granted: %u mW\n",
+ requested_mw);
+ ret = 0;
+ break;
+ case AUX_PWR_REQ_NO_MAIN_PWR_REMOVAL:
+ pci_info(bdev, "D3cold Aux Power: Main power won't be removed\n");
+ ret = -EBUSY;
+ break;
+ default:
+ if (result >= AUX_PWR_REQ_RETRY_INTERVAL_MIN &&
+ result <= AUX_PWR_REQ_RETRY_INTERVAL_MAX) {
+ pci_info(bdev, "D3cold Aux Power request needs retry interval: %u seconds\n",
+ result & 0xF);
+ if (retry_interval) {
+ *retry_interval = result & 0xF;
+ ret = -EAGAIN;
+ }
+ } else {
+ pci_err(bdev, "D3cold Aux Power: Reserved or unsupported response: 0x%x\n",
+ result);
+ }
+ break;
+ }
+
+ ACPI_FREE(out_obj);
+ return ret;
+}
+EXPORT_SYMBOL_GPL(pci_acpi_request_d3cold_aux_power);
+
static void pci_acpi_set_external_facing(struct pci_dev *dev)
{
u8 val;
diff --git a/include/linux/pci-acpi.h b/include/linux/pci-acpi.h
index 078225b514d4..ba48e7ddb360 100644
--- a/include/linux/pci-acpi.h
+++ b/include/linux/pci-acpi.h
@@ -121,6 +121,7 @@ extern const guid_t pci_acpi_dsm_guid;
#define DSM_PCI_DEVICE_NAME 0x07
#define DSM_PCI_POWER_ON_RESET_DELAY 0x08
#define DSM_PCI_DEVICE_READINESS_DURATIONS 0x09
+#define DSM_PCI_D3COLD_AUX_POWER_LIMIT 0x0A
#ifdef CONFIG_PCIE_EDR
void pci_acpi_add_edr_notifier(struct pci_dev *pdev);
@@ -132,10 +133,18 @@ static inline void pci_acpi_remove_edr_notifier(struct pci_dev *pdev) { }
int pci_acpi_set_companion_lookup_hook(struct acpi_device *(*func)(struct pci_dev *));
void pci_acpi_clear_companion_lookup_hook(void);
+int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_mw,
+ u32 *retry_interval);
#else /* CONFIG_ACPI */
static inline void acpi_pci_add_bus(struct pci_bus *bus) { }
static inline void acpi_pci_remove_bus(struct pci_bus *bus) { }
+static inline int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev,
+ u32 requested_mw,
+ u32 *retry_interval)
+{
+ return -EOPNOTSUPP;
+}
#endif /* CONFIG_ACPI */
#endif /* _PCI_ACPI_H_ */
--
2.34.1
next prev parent reply other threads:[~2025-10-15 8:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 8:06 [PATCH v5 00/12] VRAM Self Refresh Badal Nilawar
2025-10-15 8:06 ` Badal Nilawar [this message]
2025-10-27 19:03 ` [PATCH v5 01/12] PCI/ACPI: Add D3cold Aux Power Limit_DSM method Rafael J. Wysocki
2025-10-15 8:07 ` [PATCH v5 02/12] PCI/ACPI: Per Root/Switch Downstream Port allow one aux power limit request Badal Nilawar
2025-10-27 19:11 ` Rafael J. Wysocki
2025-10-15 8:07 ` [PATCH v5 03/12] PCI/ACPI: Add PERST# Assertion Delay _DSM method Badal Nilawar
2025-10-27 19:18 ` Rafael J. Wysocki
2025-10-15 8:07 ` [PATCH v5 04/12] drm/xe/vrsr: Introduce flag has_vrsr Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 05/12] drm/xe/vrsr: Detect VRSR Capability Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 06/12] drm/xe/vrsr: Initialize VRSR feature Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 07/12] drm/xe/vrsr: Enable VRSR on default VGA boot device Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 08/12] drm/xe/vrsr: Refactor d3cold.allowed to a enum Badal Nilawar
2025-10-15 8:39 ` Raag Jadav
2025-10-15 9:04 ` Nilawar, Badal
2025-10-15 9:08 ` Nilawar, Badal
2025-10-15 9:08 ` Gupta, Anshuman
2025-10-15 8:07 ` [PATCH v5 09/12] drm/xe/pm: D3cold target state Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 10/12] drm/xe/vrsr: Enable VRSR Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 11/12] drm/xe/pm/s2idle: Don't evict user BOs for D3hot and D3cold-VRSR state Badal Nilawar
2025-10-17 11:00 ` Matthew Auld
2025-10-15 8:07 ` [PATCH v5 12/12] drm/xe/vrsr: Introduce a debugfs node named vrsr_capable Badal Nilawar
2025-10-15 8:43 ` Poosa, Karthik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015080710.1468409-2-badal.nilawar@intel.com \
--to=badal.nilawar@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=uma.shankar@intel.com \
--cc=varun.gupta@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).