From: Badal Nilawar <badal.nilawar@intel.com>
To: intel-xe@lists.freedesktop.org, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org
Cc: anshuman.gupta@intel.com, rafael@kernel.org, lenb@kernel.org,
bhelgaas@google.com, ilpo.jarvinen@linux.intel.com,
lucas.demarchi@intel.com, rodrigo.vivi@intel.com,
varun.gupta@intel.com, ville.syrjala@linux.intel.com,
uma.shankar@intel.com, karthik.poosa@intel.com
Subject: [PATCH v5 07/12] drm/xe/vrsr: Enable VRSR on default VGA boot device
Date: Wed, 15 Oct 2025 13:37:05 +0530 [thread overview]
Message-ID: <20251015080710.1468409-8-badal.nilawar@intel.com> (raw)
In-Reply-To: <20251015080710.1468409-1-badal.nilawar@intel.com>
The VRSR feature is to enhance the display screen refresh experience
when the device exits from the D3cold state. Therefore, apply the VRSR
feature to the default VGA boot device and when a display is connected.
v2: Move generic display logic to i915/display (Jani)
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 22 ++++++++++++++++++++
drivers/gpu/drm/i915/display/intel_display.h | 1 +
drivers/gpu/drm/xe/display/xe_display.c | 5 +++++
drivers/gpu/drm/xe/display/xe_display.h | 2 ++
drivers/gpu/drm/xe/xe_pm.c | 5 +++++
5 files changed, 35 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index d5b2612d4ec2..b974e7dc978d 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -8300,3 +8300,25 @@ bool intel_scanout_needs_vtd_wa(struct intel_display *display)
return IS_DISPLAY_VER(display, 6, 11) && i915_vtd_active(i915);
}
+
+bool intel_display_connected(struct intel_display *display)
+{
+ struct drm_connector *list_connector;
+ struct drm_connector_list_iter iter;
+ bool ret = false;
+
+ mutex_lock(&display->drm->mode_config.mutex);
+ drm_connector_list_iter_begin(display->drm, &iter);
+
+ drm_for_each_connector_iter(list_connector, &iter) {
+ if (list_connector->status == connector_status_connected) {
+ ret = true;
+ break;
+ }
+ }
+
+ drm_connector_list_iter_end(&iter);
+ mutex_unlock(&display->drm->mode_config.mutex);
+
+ return ret;
+}
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index fc2ef92ccf68..78a479241c67 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -555,5 +555,6 @@ bool assert_port_valid(struct intel_display *display, enum port port);
bool intel_scanout_needs_vtd_wa(struct intel_display *display);
int intel_crtc_num_joined_pipes(const struct intel_crtc_state *crtc_state);
+bool intel_display_connected(struct intel_display *display);
#endif
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 47619bb8dc10..205040f43ddd 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -58,6 +58,11 @@ bool xe_display_driver_probe_defer(struct pci_dev *pdev)
return intel_display_driver_probe_defer(pdev);
}
+bool xe_display_connected(struct xe_device *xe)
+{
+ return intel_display_connected(xe->display);
+}
+
/**
* xe_display_driver_set_hooks - Add driver flags and hooks for display
* @driver: DRM device driver
diff --git a/drivers/gpu/drm/xe/display/xe_display.h b/drivers/gpu/drm/xe/display/xe_display.h
index 76db95c25f7e..11d4b09808e5 100644
--- a/drivers/gpu/drm/xe/display/xe_display.h
+++ b/drivers/gpu/drm/xe/display/xe_display.h
@@ -37,6 +37,7 @@ void xe_display_pm_resume(struct xe_device *xe);
void xe_display_pm_runtime_suspend(struct xe_device *xe);
void xe_display_pm_runtime_suspend_late(struct xe_device *xe);
void xe_display_pm_runtime_resume(struct xe_device *xe);
+bool xe_display_connected(struct xe_device *xe);
#else
@@ -67,5 +68,6 @@ static inline void xe_display_pm_runtime_suspend(struct xe_device *xe) {}
static inline void xe_display_pm_runtime_suspend_late(struct xe_device *xe) {}
static inline void xe_display_pm_runtime_resume(struct xe_device *xe) {}
+static inline bool xe_display_connected(struct xe_device *xe) { return false; }
#endif /* CONFIG_DRM_XE_DISPLAY */
#endif /* _XE_DISPLAY_H_ */
diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index d95de9015ef5..61466bf0bba6 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -9,6 +9,7 @@
#include <linux/fault-inject.h>
#include <linux/pm_runtime.h>
#include <linux/suspend.h>
+#include <linux/vgaarb.h>
#include <drm/drm_managed.h>
#include <drm/ttm/ttm_placement.h>
@@ -378,6 +379,7 @@ static int pci_acpi_aux_power_setup(struct xe_device *xe)
static void xe_pm_vrsr_init(struct xe_device *xe)
{
+ struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
int ret;
if (!xe->info.has_vrsr)
@@ -386,6 +388,9 @@ static void xe_pm_vrsr_init(struct xe_device *xe)
if (!xe_pm_vrsr_capable(xe))
return;
+ if (pdev != vga_default_device() || !xe_display_connected(xe))
+ return;
+
/*
* If the VRSR initialization fails, the device will proceed with the regular
* D3cold flow
--
2.34.1
next prev parent reply other threads:[~2025-10-15 8:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 8:06 [PATCH v5 00/12] VRAM Self Refresh Badal Nilawar
2025-10-15 8:06 ` [PATCH v5 01/12] PCI/ACPI: Add D3cold Aux Power Limit_DSM method Badal Nilawar
2025-10-27 19:03 ` Rafael J. Wysocki
2025-10-15 8:07 ` [PATCH v5 02/12] PCI/ACPI: Per Root/Switch Downstream Port allow one aux power limit request Badal Nilawar
2025-10-27 19:11 ` Rafael J. Wysocki
2025-10-15 8:07 ` [PATCH v5 03/12] PCI/ACPI: Add PERST# Assertion Delay _DSM method Badal Nilawar
2025-10-27 19:18 ` Rafael J. Wysocki
2025-10-15 8:07 ` [PATCH v5 04/12] drm/xe/vrsr: Introduce flag has_vrsr Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 05/12] drm/xe/vrsr: Detect VRSR Capability Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 06/12] drm/xe/vrsr: Initialize VRSR feature Badal Nilawar
2025-10-15 8:07 ` Badal Nilawar [this message]
2025-10-15 8:07 ` [PATCH v5 08/12] drm/xe/vrsr: Refactor d3cold.allowed to a enum Badal Nilawar
2025-10-15 8:39 ` Raag Jadav
2025-10-15 9:04 ` Nilawar, Badal
2025-10-15 9:08 ` Nilawar, Badal
2025-10-15 9:08 ` Gupta, Anshuman
2025-10-15 8:07 ` [PATCH v5 09/12] drm/xe/pm: D3cold target state Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 10/12] drm/xe/vrsr: Enable VRSR Badal Nilawar
2025-10-15 8:07 ` [PATCH v5 11/12] drm/xe/pm/s2idle: Don't evict user BOs for D3hot and D3cold-VRSR state Badal Nilawar
2025-10-17 11:00 ` Matthew Auld
2025-10-15 8:07 ` [PATCH v5 12/12] drm/xe/vrsr: Introduce a debugfs node named vrsr_capable Badal Nilawar
2025-10-15 8:43 ` Poosa, Karthik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015080710.1468409-8-badal.nilawar@intel.com \
--to=badal.nilawar@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=uma.shankar@intel.com \
--cc=varun.gupta@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).