From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B588D261B96; Thu, 4 Dec 2025 07:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764833948; cv=none; b=jTATOHate32OklvLIhQwI3zWPNiM9Kjs1Qa56aDY/LSEMhCsJmT/10rqcgqBj5wlloyvSbv260qPEZC8JSDWKqsyMg4sFE1vhP/m9R3p3WSfTgnLsw+uWU5UZui4RF4m71I4yT8x2JEmq+x5HNMLNIGKzcj8HiE57BxZ4STT63I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764833948; c=relaxed/simple; bh=ZBbFP2u19PYaompzZPpRS3munLLvOSa0dafo71gqR4A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jz6b72SMf5E7xXR7cu3EIUkv/kYYMspkKplYndV8yG2/YzmSE6JLh6Hr97T4byf/J1PE3BH67uv1SEEcRCon/tkDGGWvs8vD6WAYZ0LomcBZq5VWYcErfaxMxWgwYJQ1mQsrfA8Hl4toADXHOLwfX0h1SZe36WLjubU7MLstiAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=PtQg8yrU; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="PtQg8yrU" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 9D4731A1F38; Thu, 4 Dec 2025 07:39:03 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6351B6068C; Thu, 4 Dec 2025 07:39:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B9D2611921EB0; Thu, 4 Dec 2025 08:38:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764833941; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=k7CE06tyTx4yxeiWtpPuf1dnd1n3hRXeTtqv9aVcNzw=; b=PtQg8yrUoGAKG/Uii8S7XQtskQAWYlZadXyZzx8jkUIfm66LC9Z6ad4cKNE4THRD7VoZSf VpOBLrkjXDpI5hwZCvijtYB2Vy5ZG58J80S2F53J9dwWk7dpTNG30pcf/51U93DGiwEgRT fQpgrXdq5ncqdGM17SDz8p09cF/kH78uKk1HPXF2geoo/Iq2hdicWw0z1OcT8qIlGWX4io 9e/70u+5e6wZE/l9cV4otQ1JJW0py/fWZuwlCOsKVDmZydp44Fq5GitqLtJS5kFRhZ2OUd f1Zx5ECtIQ4aGzbOVCxCdOdmcvN4wJ599iZIa+qSHKGSWZgKnUBDj/ecIp/4rQ== Date: Thu, 4 Dec 2025 08:38:39 +0100 From: Herve Codina To: Kalle Niemi , Rob Herring , Matti Vaittinen , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org Cc: Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Ulf Hansson , Mark Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays" Message-ID: <20251204083839.4fb8a4b1@bootlin.com> In-Reply-To: References: <20251015071420.1173068-1-herve.codina@bootlin.com> <20251015071420.1173068-2-herve.codina@bootlin.com> <5cf2a12a-7c66-4622-b4a9-14896c6df005@gmail.com> <072dde7c-a53c-4525-83ac-57ea38edc0b5@gmail.com> <55076f4b-d523-4f8c-8bd4-0645b790737e@gmail.com> <20251202102619.5cd971cc@bootlin.com> <088af3ff-bd04-4bc9-b304-85f6ed555f2a@gmail.com> <20251202175836.747593c0@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Kalle, On Wed, 3 Dec 2025 12:11:45 +0200 Kalle Niemi wrote: ... > > I tried this patch on next-20251127 by manually adding the added lines > to /drivers/of/overlay.c, and it did not solve the issue. I will > continue to test this. > Did you observe same traces reported by Geert? To move forward, I think I will need help. Indeed, Kalle, Geert, I don't have your hardware, your related overlay or a similar one that could be used for test and also I don't have your out of tree code used to handle this overlay. I know overlays and fw_devlink have issues. Links created by fw_devlink when an overlay is applied were not correct on my side. Can you check your -- links with 'ls /sys/class/devlinks' On my side, without my patches some links were not correct. They linked to the parent of the supplier instead of the supplier itself. The consequence is a kernel crash, use after free, refcounting failure, ... when the supplier device is removed. Indeed, with wrong links consumers were not removed before suppliers they used. Looking at Geert traces: --- 8< --- rcar_sound ec500000.sound: Failed to create device link (0x180) with supplier soc for /soc/sound@ec500000/rcar_sound,src/src-0 rcar_sound ec500000.sound: Failed to create device link (0x180) with supplier soc for /soc/sound@ec500000/rcar_sound,src/src-1 [...] --- 8< --- Even if it is not correct, why the soc device cannot be a provider? I don't have the answer to this question yet. Without having the exact tree structure of the base device-tree, the overlay and the way it is applied, and so without been able to reproduce the issue on my side, investigating the issue is going to be difficult. I hope to find some help to move forward and fix the issue. Saravana's email (Saravana Kannan ) seems incorrect. Got emails delivery failure with this email address. Best regards, Hervé