Re: [PATCH v1 4/8] ACPI: bus: Split _OSC error processing out of acpi_run_osc()

Jonathan Cameron
2025-12-19T12:46:43Z

On Thu, 18 Dec 2025 21:36:57 +0100
"Rafael J. Wysocki" <rafael@kernel.org> wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Split a function for processing _OSL errors called acpi_osc_error_check()
_OSC?
> out of acpi_run_osc() to facilitate subsequent changes.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Minor request inline.
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> drivers/acpi/bus.c | 56 ++++++++++++++++++++++++++++++++++-------------------
> 1 file changed, 36 insertions(+), 20 deletions(-)
>
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -236,13 +236,46 @@ static int acpi_eval_osc(acpi_handle han
> return 0;
> }
>
> +static bool acpi_osc_error_check(acpi_handle handle, guid_t *guid, int rev,
> + struct acpi_buffer *cap, u32 *retbuf)
> +{
> + /* Bit 0 in the query DWORD of the return buffer is reserved. */
> + u32 errors = retbuf[OSC_QUERY_DWORD] & OSC_ERROR_MASK;
> + u32 *capbuf = cap->pointer;
> +
> + /*
> + * If OSC_QUERY_ENABLE is set in the capabilities buffer, ignore bit 4.

Maybe add a tiny bit on why?

> + */
> + if (capbuf[OSC_QUERY_DWORD] & OSC_QUERY_ENABLE)
> + errors &= ~OSC_CAPABILITIES_MASK_ERROR;
> +
> + if (!errors)
> + return false;
> +
> + if (errors & OSC_REQUEST_ERROR)
> + acpi_handle_debug(handle, "_OSC: request failed\n");
> +
> + if (errors & OSC_INVALID_UUID_ERROR)
> + acpi_handle_debug(handle, "_OSC: invalid UUID\n");
> +
> + if (errors & OSC_INVALID_REVISION_ERROR)
> + acpi_handle_debug(handle, "_OSC: invalid revision\n");
> +
> + if (errors & OSC_CAPABILITIES_MASK_ERROR)
> + acpi_handle_debug(handle, "_OSC: capability bits masked\n");
> +
> + acpi_dump_osc_data(handle, guid, rev, cap);
> +
> + return true;
> +}

>
>