[PATCH v2 1/1] ACPI: video: simplify code with acpi_get_local_u64_address()

[PATCH v2 1/1] ACPI: video: simplify code with acpi_get_local_u64_address()

[Andy Shevchenko]

Now we have a helper so there's no need to open-code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

v2: removed now unused variable (LKP)

 drivers/acpi/acpi_video.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 944aba605c1a..69469757b965 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -1134,13 +1134,11 @@ static int acpi_video_bus_get_one_device(struct acpi_device *device, void *arg)
 	struct acpi_video_bus *video = arg;
 	struct acpi_video_device_attrib *attribute;
 	struct acpi_video_device *data;
-	unsigned long long device_id;
-	acpi_status status;
 	int device_type;
+	u64 device_id;
 
-	status = acpi_evaluate_integer(device->handle, "_ADR", NULL, &device_id);
 	/* Skip devices without _ADR instead of failing. */
-	if (ACPI_FAILURE(status))
+	if (acpi_get_local_u64_address(device->handle, &device_id))
 		goto exit;
 
 	data = kzalloc(sizeof(struct acpi_video_device), GFP_KERNEL);
-- 
2.50.1

Re: [PATCH v2 1/1] ACPI: video: simplify code with acpi_get_local_u64_address()

[Rafael J. Wysocki]

On Wed, Jan 21, 2026 at 9:47 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Now we have a helper so there's no need to open-code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> v2: removed now unused variable (LKP)
>
>  drivers/acpi/acpi_video.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index 944aba605c1a..69469757b965 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -1134,13 +1134,11 @@ static int acpi_video_bus_get_one_device(struct acpi_device *device, void *arg)
>         struct acpi_video_bus *video = arg;
>         struct acpi_video_device_attrib *attribute;
>         struct acpi_video_device *data;
> -       unsigned long long device_id;
> -       acpi_status status;
>         int device_type;
> +       u64 device_id;
>
> -       status = acpi_evaluate_integer(device->handle, "_ADR", NULL, &device_id);
>         /* Skip devices without _ADR instead of failing. */
> -       if (ACPI_FAILURE(status))
> +       if (acpi_get_local_u64_address(device->handle, &device_id))
>                 goto exit;
>
>         data = kzalloc(sizeof(struct acpi_video_device), GFP_KERNEL);
> --

Applied as 6.20 material, thanks!