From: Sumeet Pawnikar <sumeet4linux@gmail.com>
To: rafael@kernel.org, robert.moore@intel.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com
Subject: [PATCH] tools/power/acpi: Replace unsafe strcat with strncat in apfiles.c
Date: Sun, 1 Feb 2026 23:48:24 +0530 [thread overview]
Message-ID: <20260201181824.4999-1-sumeet4linux@gmail.com> (raw)
Replace unsafe strcat() calls with strncat() in apfiles.c to prevent
potential buffer overflow vulnerabilities when constructing filenames.
The strncat() function performs bounds checking to ensure the
destination buffer is not overflowed.
No functional change.
Signed-off-by: Sumeet Pawnikar <sumeet4linux@gmail.com>
---
tools/power/acpi/tools/acpidump/apfiles.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/power/acpi/tools/acpidump/apfiles.c b/tools/power/acpi/tools/acpidump/apfiles.c
index d6b8a201480b..c7b71579aae6 100644
--- a/tools/power/acpi/tools/acpidump/apfiles.c
+++ b/tools/power/acpi/tools/acpidump/apfiles.c
@@ -131,10 +131,12 @@ int ap_write_to_binary_file(struct acpi_table_header *table, u32 instance)
if (instance > 0) {
snprintf(instance_str, sizeof(instance_str), "%u", instance);
- strcat(filename, instance_str);
+ strncat(filename, instance_str,
+ sizeof(filename) - strlen(filename) - 1);
}
- strcat(filename, FILE_SUFFIX_BINARY_TABLE);
+ strncat(filename, FILE_SUFFIX_BINARY_TABLE,
+ sizeof(filename) - strlen(filename) - 1);
if (gbl_verbose_mode) {
fprintf(stderr,
--
2.43.0
reply other threads:[~2026-02-01 18:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260201181824.4999-1-sumeet4linux@gmail.com \
--to=sumeet4linux@gmail.com \
--cc=acpica-devel@lists.linux.dev \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox