Re: [PATCH v1] ACPI: FPDT: expose FBPT and S3PT subtables via sysfs

[Nate DeSimone <nathaniel.l.desimone@intel.com>]

> > Add sysfs attributes at /sys/firmware/acpi/fpdt/tables/FBPT and
> > /sys/firmware/acpi/fpdt/tables/S3PT that expose the raw contents of the
> > FPDT subtables. Note that /sys/firmware/acpi/tables/FPDT only provides
> > the top level table, not the subtables. Adding access to the subtables
> > enables a usage model similar to /sys/firmware/dmi/tables/DMI, allowing
> > userspace tools to interpret newer record types (e.g. String Event
> > Records, Microcontroller Boot Performance Data Records, etc.) defined
> > in recent ACPI specifications[1] without requiring kernel changes.
>
> Is the existing (for BERT) /sys/firmware/acpi/tables/data directory a more
> appropriate spot for these? Naming the new subdirectory "tables" seems
> misleading as there aren't a top-level ACPI "FBPT" or "S3PT" tables?

I'm not experienced with the organizational semantics of sysfs. I made a
best-guess when choosing /sys/firmware/acpi/fpdt/tables/FBPT. Should I do
something like /sys/firmware/acpi/tables/data/fpdt/FBPT? That way the data
source is explicit and there won't be name collisions with other data in the
future?

Wherever the kernel maintainers think is the best place to put these new sysfs
attributes I'm completely on-board with. Please let me know where in the
filesystem they should go and I'll get a v2 patch implemented!

> Once naming is resolved, needs update to Documentation/ABI/testing/sysfs-fi=
> rmware-acpi
> for whatever names are chosed for the new files.

I will happily add that as well in a v2 patch series.

>
> Code looks good.
>
> -Tony

Thank You!
-Nate