From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9C7369979 for ; Mon, 23 Feb 2026 20:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771878814; cv=none; b=lhzOnXmZ7VRjGlsRrhB8lHd6hFE/OgnQRf/siPicArXrJ8uoClqiUMYYTvWPsCSG54ME9H/nWFZwnOzMt/1kzix54jVBi9qa26zmD+9AM+RciLoMepdWzjFX4ub2Z6SJ2LP9FlZvHJh0vAQIN7xKHwwITz8yJsdgLJCWapLUOjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771878814; c=relaxed/simple; bh=ESvyMVF+dYACKaZd3BgG8cX6TSnmtZvG/Oqd/0HHweU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IEnsz5SWDRi0E+h8oc7krzKNBsngMv7p1x92Cvte0qQXW8ZhyNMjKUXUN9VfOXS87+BLuZ9arW7kLDP3EGeY4duCbntm6gjQNGr6sfLFwKtTxWx+NgHSfVA48LC9kqcB+fGxY1h5ZDuxokoBEMY6QIJvR6BpAhX3OitVdpCfdKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=a+64DF2B; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="a+64DF2B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771878813; x=1803414813; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ESvyMVF+dYACKaZd3BgG8cX6TSnmtZvG/Oqd/0HHweU=; b=a+64DF2BDyUPXsJnJtEl+zhij6Vql9MIo36VgExlSm5K8YH8dENwL1vF nkBZHMRGb0KtbNvQtfpOO56hHt486+uIF9xQK70Vxy4y/I7e9Mq7IcDvE zlWuAPh2ESJymQ3i88d5XqHwLDA9CNUDo35xd3pz+vlIdcuEnwxiv0OsH cpYGEWG2p9JGFvjV8y8NVKV0cwymFw+xoA83ODs6vq7jPX5t+eRh0b0HP CUwCIR2Q+/bzAGXeg/U5YJ28xeuYTsrt3XsMP5AQ0krbrQb/ZVxjR4mbi gwGeqJPfeIescXBuh/Z7TfT4lwH+sjBEoLnM0qBOA7MP2UqcktHJ1IQxv A==; X-CSE-ConnectionGUID: sCP6a0eZSHaYdN/PdRHl/A== X-CSE-MsgGUID: fm9LaExhRR+pbNw1td0dVw== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="90467253" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="90467253" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 12:33:33 -0800 X-CSE-ConnectionGUID: dZSSgVerSTmU0I/oI/AvdA== X-CSE-MsgGUID: J3Ia0JU8T9+hgS/7mDMJgA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="213988161" Received: from nldesimo-desk.amr.corp.intel.com ([10.53.80.57]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 12:33:32 -0800 From: Nate DeSimone To: tony.luck@intel.com Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, nathaniel.l.desimone@intel.com, rafael@kernel.org Subject: Re: [PATCH v1] ACPI: FPDT: expose FBPT and S3PT subtables via sysfs Date: Mon, 23 Feb 2026 12:32:58 -0800 Message-ID: <20260223203258.2877-1-nathaniel.l.desimone@intel.com> X-Mailer: git-send-email 2.51.2.windows.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > > Add sysfs attributes at /sys/firmware/acpi/fpdt/tables/FBPT and > > /sys/firmware/acpi/fpdt/tables/S3PT that expose the raw contents of the > > FPDT subtables. Note that /sys/firmware/acpi/tables/FPDT only provides > > the top level table, not the subtables. Adding access to the subtables > > enables a usage model similar to /sys/firmware/dmi/tables/DMI, allowing > > userspace tools to interpret newer record types (e.g. String Event > > Records, Microcontroller Boot Performance Data Records, etc.) defined > > in recent ACPI specifications[1] without requiring kernel changes. > > Is the existing (for BERT) /sys/firmware/acpi/tables/data directory a more > appropriate spot for these? Naming the new subdirectory "tables" seems > misleading as there aren't a top-level ACPI "FBPT" or "S3PT" tables? I'm not experienced with the organizational semantics of sysfs. I made a best-guess when choosing /sys/firmware/acpi/fpdt/tables/FBPT. Should I do something like /sys/firmware/acpi/tables/data/fpdt/FBPT? That way the data source is explicit and there won't be name collisions with other data in the future? Wherever the kernel maintainers think is the best place to put these new sysfs attributes I'm completely on-board with. Please let me know where in the filesystem they should go and I'll get a v2 patch implemented! > Once naming is resolved, needs update to Documentation/ABI/testing/sysfs-fi= > rmware-acpi > for whatever names are chosed for the new files. I will happily add that as well in a v2 patch series. > > Code looks good. > > -Tony Thank You! -Nate