public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Mario Limonciello (AMD)" <superm1@kernel.org>
To: mario.limonciello@amd.com, rafael@kernel.org, lenb@kernel.org,
	W_Armin@gmx.de
Cc: "Mario Limonciello (AMD)" <superm1@kernel.org>,
	Pratap Nirujogi <pnirujog@amd.com>,
	rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org
Subject: [PATCH] ACPI: video: Don't allow MFD devices to probe
Date: Thu,  5 Mar 2026 20:51:39 -0600	[thread overview]
Message-ID: <20260306025144.604062-1-superm1@kernel.org> (raw)

After ACPI video was converted into a platform device in
commit 02c057ddefef5 ("ACPI: video: Convert the driver to a platform one")
other devices that are MFD children of LNXVIDEO are being probed.
This isn't intended.

During probe detect MFD cells and reject them.

Fixes: 02c057ddefef5 ("ACPI: video: Convert the driver to a platform one")
Reported-by: Pratap Nirujogi <pnirujog@amd.com>
Closes: https://lore.kernel.org/regressions/007e3390-6b2b-457e-83c7-c794c5952018@amd.com/
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
---
 drivers/acpi/acpi_video.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 3fa28f1abca38..2cb526775ac47 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -14,6 +14,7 @@
 #include <linux/init.h>
 #include <linux/types.h>
 #include <linux/list.h>
+#include <linux/mfd/core.h>
 #include <linux/mutex.h>
 #include <linux/input.h>
 #include <linux/backlight.h>
@@ -1988,6 +1989,9 @@ static int acpi_video_bus_probe(struct platform_device *pdev)
 	int error;
 	acpi_status status;
 
+	if (mfd_get_cell(pdev))
+		return -ENODEV;
+
 	status = acpi_walk_namespace(ACPI_TYPE_DEVICE,
 				acpi_dev_parent(device)->handle, 1,
 				acpi_video_bus_match, NULL,
-- 
2.43.0


             reply	other threads:[~2026-03-06  2:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06  2:51 Mario Limonciello (AMD) [this message]
2026-03-06  3:05 ` [PATCH] ACPI: video: Don't allow MFD devices to probe Nirujogi, Pratap
2026-03-06 10:50 ` Rafael J. Wysocki
2026-03-06 12:17   ` Rafael J. Wysocki
2026-03-06 12:37     ` Rafael J. Wysocki
2026-03-09  4:24       ` Nirujogi, Pratap
2026-03-06 12:42     ` Mario Limonciello
2026-03-06 12:46       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306025144.604062-1-superm1@kernel.org \
    --to=superm1@kernel.org \
    --cc=W_Armin@gmx.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=pnirujog@amd.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox