From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7F43350D46; Fri, 6 Mar 2026 02:35:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772764553; cv=none; b=Umfp98EpvgzhNAjvrHVUGGgwp4IQ2hsuDINNlibjW38uih2WTyQ/iK7vAfwIl3xUStML/1Cb3/JM8bQJw8f4/VdkDwNrRXedZPCtCtn4y8ePM4XtQsEsAioAcW3krQj4+d0g07FLpV0810wnaSpWeuOma+RVQC3m3jb1c/L9clI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772764553; c=relaxed/simple; bh=y5W6sLW/aDaUXUpUxv1dbppKapc3xlSNoGc5wcYGb2M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FTAjVOeoW1SKVQdQ36QRxe5TAygVDfFYjtofSTZ9uhZKMXuu+XmZJi6sMtz/suxBRPDmX0xYdixDRO0MSaJvKrf6nKd/mlKWHrjVTbUGAzA+AXbEazOdpbjNP4IwKGTmjz1n7s/mvahybx5tbl69gRydogfIxqTYCPfrGHQdI2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Tc7uRkO2; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Tc7uRkO2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772764552; x=1804300552; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=y5W6sLW/aDaUXUpUxv1dbppKapc3xlSNoGc5wcYGb2M=; b=Tc7uRkO24Wcyb/NriOTxZO8Qltx/ZobbF7QvsMRdpjiIoeqBhhJdqhoH DcyNyg89KFxK+8YB+dpz64vx1Og/hPS72O2KWgMfJyEDD0Xc7fNn1e06r isUDg9NkQdZ4QnmXO61h/M2AD9VhlPKy8tzfhdlp1j0kHNQ9uiwwdwiyq ZucuOMxLysZT4Njz7DDKNY8lSIGjY1OcXB38dAXlBSV7Ee9ed1pdF7ST+ WDSwNJj0SNuZcOVNxKkikyFTel50DLMULqFBiznfUVbar2SnktvVe1jxP MrRSCgCGXtJ32HhZb/uogwRcr1Qly2gJe973JqiZNeCCNfNlF1T1c7uOh A==; X-CSE-ConnectionGUID: BVwT8082RxeM0V0e1HXtsA== X-CSE-MsgGUID: CV3Miz6cSWWiqeGV8/b9jg== X-IronPort-AV: E=McAfee;i="6800,10657,11720"; a="84198726" X-IronPort-AV: E=Sophos;i="6.23,104,1770624000"; d="scan'208";a="84198726" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2026 18:35:52 -0800 X-CSE-ConnectionGUID: p3vTN18iSpGYBmvT220Zaw== X-CSE-MsgGUID: JmUmVkVeS7KdkehDBMsUgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,104,1770624000"; d="scan'208";a="223008504" Received: from lkp-server01.sh.intel.com (HELO 058beb05654c) ([10.239.97.150]) by orviesa003.jf.intel.com with ESMTP; 05 Mar 2026 18:35:44 -0800 Received: from kbuild by 058beb05654c with local (Exim 4.98.2) (envelope-from ) id 1vyL2T-000000000Dl-0Ljp; Fri, 06 Mar 2026 02:35:41 +0000 Date: Fri, 6 Mar 2026 10:35:17 +0800 From: kernel test robot To: Nicolin Chen , will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, bhelgaas@google.com, jgg@nvidia.com Cc: oe-kbuild-all@lists.linux.dev, rafael@kernel.org, lenb@kernel.org, praan@google.com, kees@kernel.org, baolu.lu@linux.intel.com, smostafa@google.com, Alexander.Grest@microsoft.com, kevin.tian@intel.com, miko.lenczewski@arm.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, vsethi@nvidia.com Subject: Re: [PATCH v1 2/2] iommu/arm-smmu-v3: Recover ATC invalidate timeouts Message-ID: <202603061001.fesCQb1B-lkp@intel.com> References: Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Nicolin, kernel test robot noticed the following build errors: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus rafael-pm/linux-next rafael-pm/bleeding-edge soc/for-next linus/master v7.0-rc2 next-20260305] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Nicolin-Chen/iommu-Do-not-call-pci_dev_reset_iommu_done-unless-reset-succeeds/20260305-132923 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/ca7ab934bf0f433b62a5c15d42241632c4cb9366.1772686998.git.nicolinc%40nvidia.com patch subject: [PATCH v1 2/2] iommu/arm-smmu-v3: Recover ATC invalidate timeouts config: arm64-randconfig-001-20260306 (https://download.01.org/0day-ci/archive/20260306/202603061001.fesCQb1B-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260306/202603061001.fesCQb1B-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202603061001.fesCQb1B-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c: In function 'arm_smmu_atc_recovery_worker': >> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:467:9: error: implicit declaration of function 'pci_dev_lock'; did you mean 'pci_dev_get'? [-Werror=implicit-function-declaration] 467 | pci_dev_lock(pdev); | ^~~~~~~~~~~~ | pci_dev_get >> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:471:9: error: implicit declaration of function 'pci_dev_unlock'; did you mean 'inode_unlock'? [-Werror=implicit-function-declaration] 471 | pci_dev_unlock(pdev); | ^~~~~~~~~~~~~~ | inode_unlock >> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:480:14: error: implicit declaration of function 'pci_reset_function' [-Werror=implicit-function-declaration] 480 | if (!pci_reset_function(pdev)) { | ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +467 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c 431 432 static void arm_smmu_atc_recovery_worker(struct work_struct *work) 433 { 434 struct arm_smmu_atc_recovery_param *param = 435 container_of(work, struct arm_smmu_atc_recovery_param, work); 436 struct pci_dev *pdev; 437 438 scoped_guard(mutex, ¶m->smmu->streams_mutex) { 439 struct arm_smmu_master *master; 440 441 master = arm_smmu_find_master(param->smmu, param->sid); 442 if (!master || WARN_ON(!dev_is_pci(master->dev))) 443 goto free_param; 444 pdev = to_pci_dev(master->dev); 445 pci_dev_get(pdev); 446 } 447 448 scoped_guard(spinlock_irqsave, ¶m->smmu->atc_recovery.lock) { 449 struct arm_smmu_atc_recovery_param *e; 450 451 list_for_each_entry(e, ¶m->smmu->atc_recovery.list, node) { 452 /* Device is already being recovered */ 453 if (e->pdev == pdev) 454 goto put_pdev; 455 } 456 param->pdev = pdev; 457 list_add(¶m->node, ¶m->smmu->atc_recovery.list); 458 } 459 460 /* 461 * Stop DMA (PCI) and block ATS (IOMMU) immediately, to prevent memory 462 * corruption. This must take pci_dev_lock to prevent any racy unplug. 463 * 464 * If pci_dev_reset_iommu_prepare() fails, pci_reset_function will call 465 * it again internally. 466 */ > 467 pci_dev_lock(pdev); 468 pci_clear_master(pdev); 469 if (pci_dev_reset_iommu_prepare(pdev)) 470 pci_err(pdev, "failed to block ATS!\n"); > 471 pci_dev_unlock(pdev); 472 473 /* 474 * ATC timeout indicates the device has stopped responding to coherence 475 * protocol requests. The only safe recovery is a reset to flush stale 476 * cached translations. Note that pci_reset_function() internally calls 477 * pci_dev_reset_iommu_prepare/done() as well and ensures to block ATS 478 * if PCI-level reset fails. 479 */ > 480 if (!pci_reset_function(pdev)) { 481 /* 482 * If reset succeeds, set BME back. Otherwise, fence the system 483 * from a faulty device, in which case user will have to replug 484 * the device to invoke pci_set_master(). 485 */ 486 pci_dev_lock(pdev); 487 pci_set_master(pdev); 488 pci_dev_unlock(pdev); 489 } 490 scoped_guard(spinlock_irqsave, ¶m->smmu->atc_recovery.lock) 491 list_del(¶m->node); 492 put_pdev: 493 pci_dev_put(pdev); 494 free_param: 495 kfree(param); 496 } 497 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki