* [PATCH v2 1/1] ACPI: processor: idle: Replace strlcat() with better alternative
@ 2026-03-17 8:01 Andy Shevchenko
2026-03-18 19:57 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2026-03-17 8:01 UTC (permalink / raw)
To: Rafael J. Wysocki, linux-acpi, linux-kernel
Cc: Rafael J. Wysocki, Len Brown, Andy Shevchenko
strlcpy() and strlcat() are confusing APIs and the former one already gone
from the kernel. In preparation to kill strlcat() replace it with the better
alternative.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: moved to scnprintf() to avoid GCC warning (clang was and is okay)
drivers/acpi/processor_idle.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 45b5d17443cf..479995a4c48a 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -1010,9 +1010,7 @@ static bool combine_lpi_states(struct acpi_lpi_state *local,
result->arch_flags = parent->arch_flags;
result->index = parent->index;
- strscpy(result->desc, local->desc, ACPI_CX_DESC_LEN);
- strlcat(result->desc, "+", ACPI_CX_DESC_LEN);
- strlcat(result->desc, parent->desc, ACPI_CX_DESC_LEN);
+ scnprintf(result->desc, ACPI_CX_DESC_LEN, "%s+%s", local->desc, parent->desc);
return true;
}
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] ACPI: processor: idle: Replace strlcat() with better alternative
2026-03-17 8:01 [PATCH v2 1/1] ACPI: processor: idle: Replace strlcat() with better alternative Andy Shevchenko
@ 2026-03-18 19:57 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2026-03-18 19:57 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rafael J. Wysocki, linux-acpi, linux-kernel, Rafael J. Wysocki,
Len Brown
On Tue, Mar 17, 2026 at 9:02 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> strlcpy() and strlcat() are confusing APIs and the former one already gone
> from the kernel. In preparation to kill strlcat() replace it with the better
> alternative.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> v2: moved to scnprintf() to avoid GCC warning (clang was and is okay)
>
> drivers/acpi/processor_idle.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 45b5d17443cf..479995a4c48a 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -1010,9 +1010,7 @@ static bool combine_lpi_states(struct acpi_lpi_state *local,
> result->arch_flags = parent->arch_flags;
> result->index = parent->index;
>
> - strscpy(result->desc, local->desc, ACPI_CX_DESC_LEN);
> - strlcat(result->desc, "+", ACPI_CX_DESC_LEN);
> - strlcat(result->desc, parent->desc, ACPI_CX_DESC_LEN);
> + scnprintf(result->desc, ACPI_CX_DESC_LEN, "%s+%s", local->desc, parent->desc);
> return true;
> }
>
> --
Applied as 7.1 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-18 19:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 8:01 [PATCH v2 1/1] ACPI: processor: idle: Replace strlcat() with better alternative Andy Shevchenko
2026-03-18 19:57 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox