From: Kai-Heng Feng <kaihengf@nvidia.com>
To: rafael@kernel.org
Cc: jonathan.cameron@huawei.com, helgaas@kernel.org,
guohanjun@huawei.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
acpica-devel@lists.linux.dev, linux-hardening@vger.kernel.org,
"Kai-Heng Feng" <kaihengf@nvidia.com>,
"Shiju Jose" <shiju.jose@huawei.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: [PATCH v3 2/3] PCI: hisi: Use devm_ghes_register_vendor_record_notifier()
Date: Mon, 30 Mar 2026 17:41:56 +0800 [thread overview]
Message-ID: <20260330094203.38022-3-kaihengf@nvidia.com> (raw)
In-Reply-To: <20260330094203.38022-1-kaihengf@nvidia.com>
Switch to the device-managed variant so the notifier is automatically
unregistered on device removal, allowing the open-coded remove callback
to be dropped entirely.
Cc: Shiju Jose <shiju.jose@huawei.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Kai-Heng Feng <kaihengf@nvidia.com>
---
v3:
- No change.
v2:
- New patch.
drivers/pci/controller/pcie-hisi-error.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/pci/controller/pcie-hisi-error.c b/drivers/pci/controller/pcie-hisi-error.c
index aaf1ed2b6e59..36be86d827a8 100644
--- a/drivers/pci/controller/pcie-hisi-error.c
+++ b/drivers/pci/controller/pcie-hisi-error.c
@@ -287,25 +287,16 @@ static int hisi_pcie_error_handler_probe(struct platform_device *pdev)
priv->nb.notifier_call = hisi_pcie_notify_error;
priv->dev = &pdev->dev;
- ret = ghes_register_vendor_record_notifier(&priv->nb);
+ ret = devm_ghes_register_vendor_record_notifier(&pdev->dev, &priv->nb);
if (ret) {
dev_err(&pdev->dev,
"Failed to register hisi pcie controller error handler with apei\n");
return ret;
}
- platform_set_drvdata(pdev, priv);
-
return 0;
}
-static void hisi_pcie_error_handler_remove(struct platform_device *pdev)
-{
- struct hisi_pcie_error_private *priv = platform_get_drvdata(pdev);
-
- ghes_unregister_vendor_record_notifier(&priv->nb);
-}
-
static const struct acpi_device_id hisi_pcie_acpi_match[] = {
{ "HISI0361", 0 },
{ }
@@ -317,7 +308,6 @@ static struct platform_driver hisi_pcie_error_handler_driver = {
.acpi_match_table = hisi_pcie_acpi_match,
},
.probe = hisi_pcie_error_handler_probe,
- .remove = hisi_pcie_error_handler_remove,
};
module_platform_driver(hisi_pcie_error_handler_driver);
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2026-03-30 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 9:41 [PATCH v3 0/3] ACPI: APEI: GHES: Add device-managed notifier helper and NVIDIA CPER handler Kai-Heng Feng
2026-03-30 9:41 ` [PATCH v3 1/3] ACPI: APEI: GHES: Add devm_ghes_register_vendor_record_notifier() Kai-Heng Feng
2026-03-30 12:58 ` Breno Leitao
2026-03-31 14:42 ` Shiju Jose
2026-04-01 1:55 ` Shuai Xue
2026-03-30 9:41 ` Kai-Heng Feng [this message]
2026-03-31 5:34 ` [PATCH v3 2/3] PCI: hisi: Use devm_ghes_register_vendor_record_notifier() Manivannan Sadhasivam
2026-03-31 14:43 ` Shiju Jose
2026-03-30 9:41 ` [PATCH v3 3/3] ACPI: APEI: GHES: Add NVIDIA vendor CPER record handler Kai-Heng Feng
2026-04-06 14:50 ` [PATCH v3 0/3] ACPI: APEI: GHES: Add device-managed notifier helper and NVIDIA CPER handler Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330094203.38022-3-kaihengf@nvidia.com \
--to=kaihengf@nvidia.com \
--cc=acpica-devel@lists.linux.dev \
--cc=bhelgaas@google.com \
--cc=guohanjun@huawei.com \
--cc=helgaas@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kwilczynski@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox