From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5469237F016; Sun, 12 Apr 2026 20:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776025089; cv=none; b=eYOquDmi4GFO+/nAc9kyh3o+rZpI6RzEB1OcOOUrXKP08/O88eKTJJ1Ex5sq++6H5MlEl3n2l3qXr6FOMhaVG3ZTCcxJ1fD2TgeSwrk8pDncAwWbMB8GG6bXVDS2JIs33byZODXHk9Kqj8zbxtchpo/HtgYkgS0Q3MA3Yh6oPXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776025089; c=relaxed/simple; bh=iGGMa7Z7yKs8PCJqrveaurxhweXuFiwoOym7d8SEypk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J07V50W7ylIatcqYXlk+ykteo3A0ydhevb3RCoWZJVhAlDUF2deTxJ5+1ynD4XE+Kk3OCos7zPzxUmJOYOWeJtFRRn9YICCrsPLmi7oeHePyqsaUJWWjDuaUY51H/3Niy8ZV2ewaTB+bx1wltlV6TvmWI1HQvvbIWsXtDR/d3+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=nWTfwe/l; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="nWTfwe/l" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id BAB164E429E2; Sun, 12 Apr 2026 20:18:06 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8CCA95FFB9; Sun, 12 Apr 2026 20:18:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 69A491045012A; Sun, 12 Apr 2026 22:18:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1776025085; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=AQaMeJLQws+JogYQcF2TyPERMpXvW6pBtPclJ0LsSvg=; b=nWTfwe/lLJQQ6aRVz/kxIj6bZJJgaW2Tuk9pYyyhrgEiL4OZeS/nNw22FgTszcsTwLkWZR ruvn3IgA/0OD6kkUq4o0Z/yvNVGSgbysCeiR9B4WRBB/b0CFRqbwPnZNcBhuwF8WInCTTj eGFNsloh8SG6OHPgXLS/igSoNhfIaJN92GOVuBySinHMuB/I75fFysrYzlf+lZSSzeLtdj QKRcP8RZJ8wlh/hO4u74n8ALgCAe2tBEdhw3CzqdnXO/KJR9zI5TrBgPIVNP0hmAueCtgs IFaX+UHS001PdC+pnzTsdYJMFeIIl94WoRJu7bcBJnVE3UGJZcyT1ROI/IoebA== Date: Sun, 12 Apr 2026 22:18:01 +0200 From: Alexandre Belloni To: Akhil R Cc: frank.li@nxp.com, acpica-devel@lists.linux.dev, conor+dt@kernel.org, devicetree@vger.kernel.org, ebiggers@kernel.org, krzk+dt@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, miquel.raynal@bootlin.com, p.zabel@pengutronix.de, rafael@kernel.org, robh@kernel.org, sakari.ailus@linux.intel.com, wsa+renesas@sang-engineering.com Subject: Re: [PATCH v2 04/13] i3c: master: Support ACPI enumeration of child devices Message-ID: <202604122018012539fc7c@mail.local> References: <20260410053147.27344-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410053147.27344-1-akhilrajeev@nvidia.com> X-Last-TLS-Session-Version: TLSv1.3 On 10/04/2026 11:01:47+0530, Akhil R wrote: > On Thu, 9 Apr 2026 22:17:22 -0400, Frank Li wrote: > > On Thu, Apr 09, 2026 at 04:27:34PM +0530, Akhil R wrote: > >> Although the existing subsystem allows host controllers to register > >> through the ACPI table, it was not possible to describe I3C or I2C > >> devices when using ACPI. This is because the driver relied on reg > >> property to retrieve the PID, static address etc whereas ACPI uses > >> _ADR or serial resources to describe such devices. > >> > >> Read _ADR and LVR from the ACPI resources and extract the data as per the > >> ACPI specification for an I3C bus. Also read mipi-i3c-static-address as > >> per the MIPI DISCO specifications [1] to get the static address to be > >> used. Hence enable describing the I3C or I2C devices in the ACPI > >> table, which is required if the device is using a static address or if it > >> needs some specific properties to be attached to it. > > > > Please wrap your commit message at 75 char. > > Ack. Will do. > > > > >> > >> [1] https://www.mipi.org/mipi-disco-for-i3c-download > >> > >> Signed-off-by: Akhil R > >> --- > >> drivers/i3c/master.c | 140 ++++++++++++++++++++++++++++++++++++++++--- > >> 1 file changed, 132 insertions(+), 8 deletions(-) > >> > >> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > >> index 5e0e926f61f3..08d0fcabd6f1 100644 > >> --- a/drivers/i3c/master.c > >> +++ b/drivers/i3c/master.c > >> @@ -5,6 +5,7 @@ > >> * Author: Boris Brezillon > >> */ > >> > >> +#include > >> #include > >> #include > >> #include > >> @@ -2403,6 +2404,53 @@ EXPORT_SYMBOL_GPL(i3c_master_add_i3c_dev_locked); > >> > >> #define OF_I3C_REG1_IS_I2C_DEV BIT(31) > >> > >> +#ifdef CONFIG_ACPI > > ... > > > >> +#ifdef CONFIG_ACPI > >> +static int i3c_master_add_acpi_dev(struct i3c_master_controller *master, > >> + struct fwnode_handle *fwnode) > > > > > > Can you move this and below function to previous #ifdef CONFIG_ACPI block. > > Ack. I will update, but there are some cross-dependencies. We may have to > add a few function prototypes with the headers if we have to move these > under the same block. Hope that is fine. > If you have cross-dependencies, then I guess they can sty separate blocks. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com