Linux ACPI
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@kernel.org>
To: Jassi Brar <jassisinghbrar@gmail.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
	Huisong Li <lihuisong@huawei.com>
Subject: [PATCH v2 0/3] mailbox: pcc: Improve completion handling and validation
Date: Thu, 23 Jul 2026 15:39:25 +0100	[thread overview]
Message-ID: <20260723143928.2625970-1-sudeep.holla@kernel.org> (raw)

Hi Jassi,

This series addresses three issues in the PCC mailbox controller which
are on the list for a while and discussed/reviewed. Please pick them
for v7.3 or let me know if you prefer pull request.

First, notify clients through their receive callback when a command
completes through polling, matching the interrupt-driven completion
path.

Second, centralize PCC shared memory signature checking in the mailbox
controller. Invalid signatures are reported without rejecting otherwise
working firmware, while mappings too small to contain a signature remain
fatal.

Finally, fix a race where a fast platform can signal command completion
before the channel is marked in use, causing a shared interrupt to be
ignored and the command to time out. Publish the channel state before
ringing the doorbell and use READ_ONCE()/WRITE_ONCE() for the lockless
flag accesses.


Regards,
Sudeep

Changes in v2:
- Reworked to keep chan_in_use set after a successful doorbell write
  and clear it only when the write fails.
- Clarified that ordering is provided by the ordered I/O accessor,
  covering both MMIO and port I/O doorbells.
- Clarified the cross-CPU flag access and interrupt-side clearing
  before the mailbox core can submit another transfer.
- Link to v1: https://lore.kernel.org/all/20260717075649.467172-1-sudeep.holla@kernel.org

Huisong Li (1):
  mailbox: pcc: Fix command timeout due to missed interrupt

Sudeep Holla (2):
  mailbox: pcc: Notify clients on polled completion
  mailbox: pcc: Check shared memory signature on request

 drivers/mailbox/pcc.c | 87 +++++++++++++++++++++++++++++++++----------
 1 file changed, 67 insertions(+), 20 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-07-23 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 14:39 Sudeep Holla [this message]
2026-07-23 14:39 ` [PATCH v2 1/3] mailbox: pcc: Notify clients on polled completion Sudeep Holla
2026-07-26  5:32   ` Adam Young
2026-07-23 14:39 ` [PATCH v2 2/3] mailbox: pcc: Check shared memory signature on request Sudeep Holla
2026-07-26  5:34   ` Adam Young
2026-07-23 14:39 ` [PATCH v2 3/3] mailbox: pcc: Fix command timeout due to missed interrupt Sudeep Holla
2026-07-26  5:33   ` Adam Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723143928.2625970-1-sudeep.holla@kernel.org \
    --to=sudeep.holla@kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=lihuisong@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox