From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA193F1653 for ; Fri, 24 Jul 2026 08:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882692; cv=none; b=KTbuNKnqRFDEYLSwsM+DXUdGwJ9f5TE+SJTHYq8+v0yrCYVSGK+Y+KoVCjG3e1dqAnmVHuNAP/QZlL4KZPS0oQLIO50Vvs0AzyYZcGos46YN9GTfkwZ2de0nhuPsiZG/NgsfML17JEScJtmg5V/+EsGF217WkrJahODOG1IQOms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882692; c=relaxed/simple; bh=DyEec2Z7+FSSh+lvskH9h+/zSvQpOnJC1n/aL86DbdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SA57aJHkwQpefzc8Ae2twsu7oeNbSOVqKRe2OVxqA0sTEDClUH0OMTqBtp1KNZrQKfSj+pNZLO5JFhwwVhDwQK75ul4V9nIP9G58RbYEPsc8KgCjR+QHyJi+W1JZ2LL69Br0p3NtIHneBGB0xKiVk0x1GNTh76rMZaGn9S8YYKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ncvlba2Y; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ncvlba2Y" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38dcbade417so169863a91.1 for ; Fri, 24 Jul 2026 01:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784882690; x=1785487490; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f0rgL0VJ5kE0g1GPB7mxKos5pVHLgytmLF2hovXGdFw=; b=Ncvlba2YNu3OM1Xj6EntAJVtCNguGJud41Y1ZLDetGb0xnij4xGqWytxDzmF5/rv93 xfM42s+nITAVn0EHuFPgGj2FR3VEUqYFEgQDSJsNampMxHOCGH+yifOzBNIgAgxj5wWE U7bo7o1FdFjTOaBBOKbKpAgutiIKVw2LoPI54= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784882690; x=1785487490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=f0rgL0VJ5kE0g1GPB7mxKos5pVHLgytmLF2hovXGdFw=; b=FWkDowiZNHTUtLKI13I98VTI50C8dy1BquUYRbRvKOHIuRlFIZ92QBCjPG2c9nKxcn UN1oTPiUJyqcKqvDxpHErkpsvOU+IVOHhqildJw+LhGGfyxd1GbHgWcXMhIRl8ETuJek kgtYbvolNASACc4lZgtVS0gHyDbzZrN5uDrhDhiYUvOPvOe9FRdtupIr2OxVJ1HGNO8T ws2VuBL0zum7TVkGtPqW+MHNbExz63GVgucyO9nEkUkegb9zEnFknZcNGaTIVZ+m7+Uq m1KJna0owLT+/mM2xNF4E47rNT2DQ6p7Smm31zzTd2EvWY9gj9rCDt43r4vEhNwwVF8X 8pfg== X-Forwarded-Encrypted: i=1; AHgh+RpXvqNNMxhdxgxA5w1dQNPXmG9HT0bS051aX6ewc+E2sQBNTf2j8avBTryReCQFroIzIeBFVu++N9Ml@vger.kernel.org X-Gm-Message-State: AOJu0YyAMHSHgL4Ldsp2clbaf/EECKxGvGagqx+U59eAY500ph9goqjj CjJ/5SfmmGR1jSv4xv8I+qJRoX5h5fVl3RsOxgxfHqUByKOdXcqYNBZ1jq8+MWyJLw== X-Gm-Gg: AR+sD13xzBJvTrQiSQdZ+e/FG20yulXUbs/chk9X/eY3NdHbsg3/AedhwVJgSf643d7 oNRnfC0rEluPg6nJS2lm9MIpMoY4lJcUvGWomuD3LtFSg4Uwna1qbrIIXC8f9dtEuALd1C6oAOC Na7loGnyofoii24EAfq84VhteUISsSvEK6byz0jE1MeiKQcpaUei8yYyYqWvtpijZW3VE16Ne4m iSdY2nGMUAVhpWkcCnUCoIQv5/wjyiFf1EI7C0Pp+mOVUxpzCjohzCYVLhcldQqRfaWL9QtgKvH SSX3wjMwWby+zEZxF2ZCOLD6D23DL6wIY5CCS9BCmWacdhU6p8pZIbBEmDqRCVWrgMfJRhWASVV jknquvbWRoz/GnWPNECg9HbS02fmTgdkFnjSj/klBJAx6w1frmJuS6yMrH2GQoKb4dYohyDdWy1 +inT0ycXb6U+ci5MpOvBTlxUDYrHsT5MeHWbE/FCuRSXcLbfjPyp46QWOcnwg= X-Received: by 2002:a17:90b:2750:b0:381:5ab5:b667 with SMTP id 98e67ed59e1d1-38ec6637d1amr6239942a91.31.1784882690591; Fri, 24 Jul 2026 01:44:50 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:f131:86cc:5858:7325]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f089ac6d8sm434546a91.2.2026.07.24.01.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 01:44:49 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v7 09/16] usb: hub: Use usb_hub_set_port_power() to control port power everywhere Date: Fri, 24 Jul 2026 16:43:18 +0800 Message-ID: <20260724084328.3943997-10-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260724084328.3943997-1-wenst@chromium.org> References: <20260724084328.3943997-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are still some instances in the USB hub driver where port power is directly controlled by toggling the USB_PORT_FEAT_POWER feature flag. Switch these instances over to usb_hub_set_port_power() so that only one unified function to do this exists. This makes adding external power control with the power sequencing API easier and consistently applied. Reviewed-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Changes since v2: - New patch --- drivers/usb/core/hub.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 6671b5e45191..a5c5038e1604 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -976,11 +976,8 @@ static void hub_power_on(struct usb_hub *hub, bool do_delay) dev_dbg(hub->intfdev, "trying to enable port power on " "non-switchable hub\n"); for (port1 = 1; port1 <= hub->hdev->maxchild; port1++) - if (test_bit(port1, hub->power_bits)) - set_port_feature(hub->hdev, port1, USB_PORT_FEAT_POWER); - else - usb_clear_port_feature(hub->hdev, port1, - USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hub->hdev, hub, port1, + test_bit(port1, hub->power_bits)); if (do_delay) msleep(hub_power_on_good_delay(hub)); } @@ -5437,7 +5434,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, if (hub_is_port_power_switchable(hub) && !usb_port_is_power_on(port_dev, portstatus) && !port_dev->port_owner) - set_port_feature(hdev, port1, USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hdev, hub, port1, true); if (portstatus & USB_PORT_STAT_ENABLE) goto done; -- 2.55.0.229.g6434b31f56-goog