From: kernel test robot <lkp@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: oe-kbuild-all@lists.linux.dev, linux-acpi@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: [rafael-pm:bleeding-edge 84/100] drivers/thunderbolt/acpi.c:31:6: warning: variable 'dev' is used uninitialized whenever 'if' condition is true
Date: Tue, 15 Sep 2026 05:04:40 +0200 [thread overview]
Message-ID: <202609150550.ZyqBeGWm-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: c4effca721d9748be701b3c3b8a666b380b2a4e5
commit: b9097c67f26d601c7585c1765ccd9984cc1d67bf [84/100] thunderbolt: Switch to use acpi_bus_get_primary_device()
config: i386-randconfig-051-20260915 (https://download.01.org/0day-ci/archive/20260915/202609150550.ZyqBeGWm-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260915/202609150550.ZyqBeGWm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609150550.ZyqBeGWm-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/thunderbolt/acpi.c:31:6: warning: variable 'dev' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
31 | if (dev_fwnode(nhi->dev) != fwnode)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/property.h:36:2: note: expanded from macro 'dev_fwnode'
36 | _Generic((dev), \
| ^
drivers/thunderbolt/acpi.c:77:13: note: uninitialized use occurs here
77 | put_device(dev);
| ^~~
drivers/thunderbolt/acpi.c:31:2: note: remove the 'if' if its condition is always false
31 | if (dev_fwnode(nhi->dev) != fwnode)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
32 | goto out_put;
| ~~~~~~~~~~~~
drivers/thunderbolt/acpi.c:21:20: note: initialize the variable 'dev' to silence this warning
21 | struct device *dev;
| ^
| = NULL
1 warning generated.
vim +31 drivers/thunderbolt/acpi.c
b2be2b05cf3b1c Mika Westerberg 2019-04-02 13
b2be2b05cf3b1c Mika Westerberg 2019-04-02 14 static acpi_status tb_acpi_add_link(acpi_handle handle, u32 level, void *data,
408e1d965a1d5f Mika Westerberg 2022-12-27 15 void **ret)
b2be2b05cf3b1c Mika Westerberg 2019-04-02 16 {
7f7b571becf373 Rafael J. Wysocki 2022-02-01 17 struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
b2be2b05cf3b1c Mika Westerberg 2019-04-02 18 struct fwnode_handle *fwnode;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 19 struct tb_nhi *nhi = data;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 20 struct pci_dev *pdev;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 21 struct device *dev;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 22
7f7b571becf373 Rafael J. Wysocki 2022-02-01 23 if (!adev)
b2be2b05cf3b1c Mika Westerberg 2019-04-02 24 return AE_OK;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 25
2ae18cc2269fc2 Heikki Krogerus 2022-10-24 26 fwnode = fwnode_find_reference(acpi_fwnode_handle(adev), "usb4-host-interface", 0);
2ae18cc2269fc2 Heikki Krogerus 2022-10-24 27 if (IS_ERR(fwnode))
b2be2b05cf3b1c Mika Westerberg 2019-04-02 28 return AE_OK;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 29
b2be2b05cf3b1c Mika Westerberg 2019-04-02 30 /* It needs to reference this NHI */
8c3ff7c5ae15cc Konrad Dybcio 2026-05-21 @31 if (dev_fwnode(nhi->dev) != fwnode)
b2be2b05cf3b1c Mika Westerberg 2019-04-02 32 goto out_put;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 33
b2be2b05cf3b1c Mika Westerberg 2019-04-02 34 /*
f20998f23a8ce3 Mathias Nyman 2024-08-30 35 * Ignore USB3 ports here as USB core will set up device links between
f20998f23a8ce3 Mathias Nyman 2024-08-30 36 * tunneled USB3 devices and NHI host during USB device creation.
f20998f23a8ce3 Mathias Nyman 2024-08-30 37 * USB3 ports might not even have a physical device yet if xHCI driver
f20998f23a8ce3 Mathias Nyman 2024-08-30 38 * isn't bound yet.
b2be2b05cf3b1c Mika Westerberg 2019-04-02 39 */
b9097c67f26d60 Rafael J. Wysocki 2026-09-14 40 dev = acpi_bus_get_primary_device(adev);
f20998f23a8ce3 Mathias Nyman 2024-08-30 41 if (!dev || !dev_is_pci(dev))
b2be2b05cf3b1c Mika Westerberg 2019-04-02 42 goto out_put;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 43
f20998f23a8ce3 Mathias Nyman 2024-08-30 44 /* Check that this matches a PCIe root/downstream port. */
b2be2b05cf3b1c Mika Westerberg 2019-04-02 45 pdev = to_pci_dev(dev);
f20998f23a8ce3 Mathias Nyman 2024-08-30 46 if (pci_is_pcie(pdev) &&
b2be2b05cf3b1c Mika Westerberg 2019-04-02 47 (pci_pcie_type(pdev) == PCI_EXP_TYPE_ROOT_PORT ||
f20998f23a8ce3 Mathias Nyman 2024-08-30 48 pci_pcie_type(pdev) == PCI_EXP_TYPE_DOWNSTREAM)) {
b2be2b05cf3b1c Mika Westerberg 2019-04-02 49 const struct device_link *link;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 50
f3380cac0c0b3a Mika Westerberg 2021-11-14 51 /*
f3380cac0c0b3a Mika Westerberg 2021-11-14 52 * Make them both active first to make sure the NHI does
f3380cac0c0b3a Mika Westerberg 2021-11-14 53 * not runtime suspend before the consumer. The
f3380cac0c0b3a Mika Westerberg 2021-11-14 54 * pm_runtime_put() below then allows the consumer to
f3380cac0c0b3a Mika Westerberg 2021-11-14 55 * runtime suspend again (which then allows NHI runtime
f3380cac0c0b3a Mika Westerberg 2021-11-14 56 * suspend too now that the device link is established).
f3380cac0c0b3a Mika Westerberg 2021-11-14 57 */
f3380cac0c0b3a Mika Westerberg 2021-11-14 58 pm_runtime_get_sync(&pdev->dev);
f3380cac0c0b3a Mika Westerberg 2021-11-14 59
8c3ff7c5ae15cc Konrad Dybcio 2026-05-21 60 link = device_link_add(&pdev->dev, nhi->dev,
b2be2b05cf3b1c Mika Westerberg 2019-04-02 61 DL_FLAG_AUTOREMOVE_SUPPLIER |
f3380cac0c0b3a Mika Westerberg 2021-11-14 62 DL_FLAG_RPM_ACTIVE |
b2be2b05cf3b1c Mika Westerberg 2019-04-02 63 DL_FLAG_PM_RUNTIME);
b2be2b05cf3b1c Mika Westerberg 2019-04-02 64 if (link) {
8c3ff7c5ae15cc Konrad Dybcio 2026-05-21 65 dev_dbg(nhi->dev, "created link from %s\n",
b2be2b05cf3b1c Mika Westerberg 2019-04-02 66 dev_name(&pdev->dev));
408e1d965a1d5f Mika Westerberg 2022-12-27 67 *(bool *)ret = true;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 68 } else {
8c3ff7c5ae15cc Konrad Dybcio 2026-05-21 69 dev_warn(nhi->dev, "device link creation from %s failed\n",
b2be2b05cf3b1c Mika Westerberg 2019-04-02 70 dev_name(&pdev->dev));
b2be2b05cf3b1c Mika Westerberg 2019-04-02 71 }
f3380cac0c0b3a Mika Westerberg 2021-11-14 72
f3380cac0c0b3a Mika Westerberg 2021-11-14 73 pm_runtime_put(&pdev->dev);
b2be2b05cf3b1c Mika Westerberg 2019-04-02 74 }
b2be2b05cf3b1c Mika Westerberg 2019-04-02 75
b2be2b05cf3b1c Mika Westerberg 2019-04-02 76 out_put:
b9097c67f26d60 Rafael J. Wysocki 2026-09-14 77 put_device(dev);
2ae18cc2269fc2 Heikki Krogerus 2022-10-24 78 fwnode_handle_put(fwnode);
b2be2b05cf3b1c Mika Westerberg 2019-04-02 79 return AE_OK;
b2be2b05cf3b1c Mika Westerberg 2019-04-02 80 }
b2be2b05cf3b1c Mika Westerberg 2019-04-02 81
:::::: The code at line 31 was first introduced by commit
:::::: 8c3ff7c5ae15cc71000f10f4d0f26669b9471faa thunderbolt: Move pci_device out of tb_nhi
:::::: TO: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
:::::: CC: Mika Westerberg <mika.westerberg@linux.intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-09-15 3:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202609150550.ZyqBeGWm-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox