Re: [PATCH v3] ACPI: button: Report wakeup key only for power button wakeups

[Baorui.Liu <baorliu@amd.com>]

Hi Rafael,

I reviewed the Sashiko findings and agree with both of them.

1) High: race in acpi_button_suspend()
Clearing wakeup_pending after setting suspended=true can lose a
power-button SCI that arrives between the two stores. I will clear
wakeup_pending before setting suspended.

2) Medium: removing acpi_clear_event(POWER_BUTTON)
Dropping the status-bit clear can allow a deferred STATUS notify to
report KEY_POWER after resume has cleared suspended, which may confuse
userspace. I will keep clearing the fixed power-button status bit, mark
wakeup_pending so button resume can still report KEY_WAKEUP, and keep
the PM wakeup event on the fixed power-button device. KEY_WAKEUP is
still not synthesized from the generic ACPI sleep path for non-power
wakes.

I will send a v4 with these updates.

Thanks,
Baorui