Linux ACPI
 help / color / mirror / Atom feed
From: Pierre Gondois <pierre.gondois@arm.com>
To: linux-kernel@vger.kernel.org
Cc: James Morse <james.morse@arm.com>,
	Mark Brown <broonie@kernel.org>,
	Pierre Gondois <pierre.gondois@arm.com>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Pawel Chmielewski <pawel.chmielewski@intel.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	Radu Rendec <radu@rendec.net>,
	Avadhut Naik <avadhut.naik@amd.com>, Kees Cook <kees@kernel.org>,
	Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>,
	Dave Jiang <dave.jiang@intel.com>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
	Breno Leitao <leitao@debian.org>,
	Terry Bowman <terry.bowman@amd.com>,
	Dan Williams <djbw@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
	Morduan Zang <zhangdandan@uniontech.com>,
	linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
	acpica-devel@lists.linux.dev
Subject: [RFC PATCH 6/6] cper: make cper_mem_err_pack() static
Date: Tue, 29 Sep 2026 09:46:05 +0200	[thread overview]
Message-ID: <20260929074659.2587216-7-pierre.gondois@arm.com> (raw)
In-Reply-To: <20260929074659.2587216-1-pierre.gondois@arm.com>

Make cper_mem_err_pack() local to cper.c and drop its public
declaration as it is only used in the local file.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 drivers/firmware/efi/cper.c | 5 ++---
 include/linux/cper.h        | 2 --
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
index e0ba2ca498e75..066359c549aff 100644
--- a/drivers/firmware/efi/cper.c
+++ b/drivers/firmware/efi/cper.c
@@ -392,8 +392,8 @@ static void cper_mem_err_old_pack(const struct cper_sec_mem_err_old *mem,
 	cmem->error_type = mem->error_type;
 }

-void cper_mem_err_pack(const struct cper_sec_mem_err *mem,
-		       struct cper_mem_err_compact *cmem)
+static void cper_mem_err_pack(const struct cper_sec_mem_err *mem,
+			      struct cper_mem_err_compact *cmem)
 {
 	memset(cmem, 0, sizeof(*cmem));
 	cmem->validation_bits = mem->validation_bits;
@@ -419,7 +419,6 @@ void cper_mem_err_pack(const struct cper_sec_mem_err *mem,
 	if (mem->validation_bits & CPER_MEM_VALID_CHIP_ID)
 		cmem->chip_id = mem->extended >> CPER_MEM_CHIP_ID_SHIFT;
 }
-EXPORT_SYMBOL_GPL(cper_mem_err_pack);

 static void cper_mem_err2_pack(const struct cper_sec_mem_err2 *mem,
 			       struct cper_mem_err_compact *cmem)
diff --git a/include/linux/cper.h b/include/linux/cper.h
index ac236043ce859..dac8e0b83a9fa 100644
--- a/include/linux/cper.h
+++ b/include/linux/cper.h
@@ -627,8 +627,6 @@ void cper_print_bits(const char *prefix, unsigned int bits,
 		     const char * const strs[], unsigned int strs_size);
 int cper_bits_to_str(char *buf, int buf_size, unsigned long bits,
 		     const char * const strs[], unsigned int strs_size);
-void cper_mem_err_pack(const struct cper_sec_mem_err *,
-		       struct cper_mem_err_compact *);
 bool cper_sec_is_platform_mem(const guid_t *sec_type);
 int cper_mem_err_parse(const guid_t *sec_type, const void *mem, size_t len,
 		       struct cper_mem_err_compact *cmem);
--
2.43.0

  parent reply	other threads:[~2026-09-29  7:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  7:45 [RFC PATCH 0/6] CPER: Add Memory Error Section 2 support Pierre Gondois
2026-09-29  7:46 ` [RFC PATCH 1/6] ACPI: extlog: fix extlog_mem_event build issue Pierre Gondois
2026-09-29  7:46 ` [RFC PATCH 2/6] cper: add Memory Error Section 2 structures Pierre Gondois
2026-09-29  7:46 ` [RFC PATCH 3/6] cper: extend cper_mem_err_compact struct Pierre Gondois
2026-09-29  7:46 ` [RFC PATCH 4/6] cper: add helpers to handle Memory Error Section 2 Pierre Gondois
2026-09-29  7:46 ` [RFC PATCH 5/6] x86/mce/apei: switch cper_sec_mem_err struct users to compact CPER records Pierre Gondois
2026-09-29  7:46 ` Pierre Gondois [this message]
2026-09-29 16:35 ` [RFC PATCH 0/6] CPER: Add Memory Error Section 2 support Jonathan Cameron
2026-10-07 13:35   ` Pierre Gondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929074659.2587216-7-pierre.gondois@arm.com \
    --to=pierre.gondois@arm.com \
    --cc=acpica-devel@lists.linux.dev \
    --cc=ardb@kernel.org \
    --cc=avadhut.naik@amd.com \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=djbw@kernel.org \
    --cc=fabio.m.de.francesco@linux.intel.com \
    --cc=guohanjun@huawei.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=kees@kernel.org \
    --cc=leitao@debian.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawel.chmielewski@intel.com \
    --cc=radu@rendec.net \
    --cc=rafael@kernel.org \
    --cc=terry.bowman@amd.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    --cc=yazen.ghannam@amd.com \
    --cc=zhangdandan@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox