From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Zenghui Yu <yuzenghui@huawei.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"xueshuai@linux.alibaba.com" <xueshuai@linux.alibaba.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"wangzhigang17@huawei.com" <wangzhigang17@huawei.com>
Subject: Re: [PATCH] ACPI: APEI: EINJ: Validate length of the Vendor Error Type Extension structure
Date: Fri, 13 Nov 2026 10:37:09 +0100 [thread overview]
Message-ID: <20261113103709.13bfd3d6@foz.lan> (raw)
In-Reply-To: <CH8PR11MB40343305FD3C1BE0E18882B5CCFC7F2@CH8PR11MB403433.namprd11.prod.outlook.com>
On Fri, 13 Nov 2026 00:27:20 +0000
"Luck, Tony" <tony.luck@intel.com> wrote:
> > The BIOS on my machine is obviously buggy (non-zero Vendor Extension offset
> > pointing to zeroed memory, and bit 31 is not set in the error type either)
> > and needs fixing. I'm not sure if it is necessary to add such a sanity
> > check for EINJ at all.
>
> Production machine? Or just an internal development machine? I.e. is this broken
> BIOS out in the wild for others to hit this bug?
As a reminder, any VM runs with a BIOS that is not produced by an OEM, and
there are lots of production environments running VMs out there.
So, I'd say that, if the fix is good, better apply it.
From my side:
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thanks,
Mauro
prev parent reply other threads:[~2026-11-13 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 11:57 [PATCH] ACPI: APEI: EINJ: Validate length of the Vendor Error Type Extension structure Zenghui Yu
2026-11-13 0:27 ` Luck, Tony
2026-11-13 9:23 ` Zenghui Yu
2026-11-13 9:37 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113103709.13bfd3d6@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=bp@alien8.de \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=wangzhigang17@huawei.com \
--cc=xueshuai@linux.alibaba.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox