[PATCH 01/32] ACPICA: Headers: Delete bogus node_array array of pointers from AEST table

Rafael J. Wysocki
2023-04-05T14:05:25Z

From: Jessica Clarke <jrtc27@jrtc27.com>

ACPICA commit f0c4a06f1dfc4886d4e0c2aa30bc57b10c5a8c53

Like many tables, this is a header followed by multiple subtables of
varying self-identifying types, and ACPICA does not normally add a field
for the subtables, instead relying on pointer arithmetic past the end of
the first header struct, since indexing a flexible array member is
meaningless for variable-length entries. If we really wanted a field for
this, we could use a u8 flexible array member, but it contradicts the
current style. Using void *, however, is categorically wrong, as ACPI
tables never contain native C-language pointers.

Link: https://github.com/acpica/acpica/commit/f0c4a06f
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
include/acpi/actbl2.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
index b2973dbe37ee..2e7e0d5674f6 100644
--- a/include/acpi/actbl2.h
+++ b/include/acpi/actbl2.h
@@ -82,7 +82,6 @@

struct acpi_table_aest {
struct acpi_table_header header;
- void *node_array[];
};

/* Common Subtable header - one per Node Structure (Subtable) */
--
2.35.3