From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Matthew Garrett <matthew.garrett@coreos.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
linux-acpi@vger.kernel.org,
Mario Limonciello <mario_limonciello@dell.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/4] acpi: allow for an override to set _REV
Date: Fri, 22 May 2015 03:02:56 +0200 [thread overview]
Message-ID: <2151643.NYQBfFsFjv@vostro.rjw.lan> (raw)
In-Reply-To: <CAPeXnHv07HkvcHrYFmZMr8OTp7U7F=k_k=LPYnUtp89iPn2d2Q@mail.gmail.com>
On Thursday, May 21, 2015 11:10:20 AM Matthew Garrett wrote:
> On Wed, May 20, 2015 at 6:24 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> > Which doesn't explain why we need a config option per quirk. To me, such config
> > options don't add any value, because (a) everyone will set them anyway and (b)
> > removing the quirks from the source is trivial if needed.
>
> We'd disable this quirk in Fedora the moment jack detection works,
> because we've got the userspace to handle it and using I2S is
> preferable to using HDA - but in doing so we might break battery
> detection on the other Dell that's playing _REV tricks. This seems
> like a suboptimal choice to have to make.
What about removing the quirk from the table in that case? Do we
really need a special config option around it?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-05-22 0:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 13:31 [PATCH 0/4] ACPI: provide an override for _REV Dominik Brodowski
2015-05-14 13:31 ` [PATCH 1/4] acpi: use same type for acpi_predefined_names values as in definition Dominik Brodowski
2015-05-14 13:31 ` [PATCH 2/4] acpi: allow for an override to set _REV Dominik Brodowski
2015-05-14 14:18 ` Dominik Brodowski
2015-05-14 20:36 ` Rafael J. Wysocki
2015-05-14 21:55 ` Rafael J. Wysocki
2015-05-17 17:41 ` Dominik Brodowski
2015-05-18 1:01 ` Rafael J. Wysocki
2015-05-18 4:47 ` Dominik Brodowski
2015-05-21 1:24 ` Rafael J. Wysocki
2015-05-21 10:24 ` Dominik Brodowski
2015-05-22 1:11 ` Rafael J. Wysocki
2015-05-21 18:10 ` Matthew Garrett
2015-05-21 18:18 ` Mario Limonciello
2015-05-22 1:13 ` Rafael J. Wysocki
2015-05-22 21:19 ` Mario_Limonciello
2015-05-22 22:15 ` Rafael J. Wysocki
2015-06-30 20:11 ` Rafael J. Wysocki
2015-05-22 1:02 ` Rafael J. Wysocki [this message]
2015-05-14 13:31 ` [PATCH 3/4] acpi: add _REV quirk for Dell XPS 13 (2015) Dominik Brodowski
2015-05-14 13:31 ` [PATCH 4/4] acpi: fix kernel-parameters ordering in Documentation Dominik Brodowski
2015-05-14 20:31 ` [PATCH 0/4] ACPI: provide an override for _REV Rafael J. Wysocki
2015-05-14 23:56 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2151643.NYQBfFsFjv@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mario_limonciello@dell.com \
--cc=matthew.garrett@coreos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox