public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	lenb@kernel.org, linux-acpi@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / platform / LPSS: disable async suspend/resume of LPSS devices
Date: Tue, 23 Sep 2014 01:17:08 +0200	[thread overview]
Message-ID: <2190534.fECTUJ0MGh@vostro.rjw.lan> (raw)
In-Reply-To: <54203616.2040803@linux.intel.com>

On Monday, September 22, 2014 10:45:42 PM Fu, Zhonghui wrote:
> 

[cut]

> >>>
> >>> This operation is reading data from Operation Region of one operand object in name space. I don't know the reason of hang at this point. Could you please give out some explanation about this?
> >> I don't know the exact reason why this particular read hangs, but this means
> >> that, perhaps, instead of disabling async suspend/resume for all LPSS devices
> >> altogether, perhaps we can serialize their acpi_dev_resume_early()?
> >>
> >> Rafael
> > Do you mean keeping other phases(prepare, suspend, suspend_late, suspend_noirq, resume_noirq, resume, complete) of suspend/resume asynchronous, and only serializing "resume_early" phase for all LPSS devices?
> >
> > Thanks,
> > Zhonghui
> Hi, Rafael
> 
> Could you please confirm my understanding?

This is not what I meant.

Since we have a PM domain for the LPSS devices already, why don't we add an
internal lock to that PM domain and acquire it over executing either
acpi_dev_suspend_late() (during suspend) or acpi_dev_resume_early() (during
resume) for all of them?

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  parent reply	other threads:[~2014-09-22 22:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  5:36 [PATCH] ACPI / platform / LPSS: disable async suspend/resume of LPSS devices Fu, Zhonghui
2014-09-09 13:17 ` Rafael J. Wysocki
2014-09-12 17:40   ` Fu, Zhonghui
2014-09-10  7:50 ` Mika Westerberg
2014-09-12 17:53   ` Fu, Zhonghui
2014-09-14 16:52     ` Rafael J. Wysocki
     [not found] ` <54184C92.7060209@linux.intel.com>
     [not found]   ` <54203616.2040803@linux.intel.com>
2014-09-22 23:17     ` Rafael J. Wysocki [this message]
     [not found]       ` <5422E0FA.5090600@linux.intel.com>
2014-09-24 20:32         ` Rafael J. Wysocki
2014-09-25  2:07           ` Li, Aubrey
2014-09-25 20:08             ` Rafael J. Wysocki
2014-09-26  3:54               ` Li, Aubrey
2014-09-26 14:06                 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2190534.fECTUJ0MGh@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=zhonghui.fu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox