Re: [PATCH v7 13/17] ARM64 / ACPI: Add GICv2 specific ACPI boot support

Marc Zyngier
2015-01-22T14:46:21Z

Hi Hanjun,

On 22/01/15 12:46, Hanjun Guo wrote:
> Hi Marc,
>
> We (Tomasz, Suravee and me) are working on supporting stacked domain on
> ACPI, and rework GIC ACPI related patch, before we going further, we
> need your guidance to see if we are going the right direction.
>
> - You said that we spread GIC related code every where, so how
> about put all the ACPI related GIC init code in one file under
> drivers/irqchip/ with name irq-gic-acpi.c?

That would certainly be an improvement.

> - ACPI only support one GICD for now, so we assume that there
> only one gicv2/v3 core domain and every device not using MSI
> will refer to that irqdomain in default.

That's good enough, provided that nobody comes up with any form of
chained interrupt controller (in whatever way that's implemented). ACPI
doesn't seem to cater for that anyway.

But default domains are only a quick optimization (it is only there to
cope with code that didn't know about irq domains at all). What we need
is a proper integration of the ACPI namespace in the irq domain code.
Being able to lookup a domain by ACPI table, for example (just like
irq_find_host returns the domain associated to a DT node).

This would ensure that we can reuse most of the existing code (stacked
domains, per-device MSI domains [WIP]) without too much effort.

Thanks,

M.
--
Jazz is not dead. It just smells funny...