From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Dumbre, Saket" <saket.dumbre@intel.com>
Subject: [PATCH v1 08/16] ACPICA: Debugger: drop ACPI_NONSTRING attribute from name_seg
Date: Fri, 12 Sep 2025 21:59:17 +0200 [thread overview]
Message-ID: <2252228.Mh6RI2rZIc@rafael.j.wysocki> (raw)
In-Reply-To: <2021361.PYKUYFuaPT@rafael.j.wysocki>
From: Ahmed Salem <x0rw3ll@gmail.com>
ACPICA commit 4623b3369f3aa1ec5229d461e91c514510a96912
Partially revert commit 70662db73d54 ("ACPICA: Apply ACPI_NONSTRING in
more places") as I've yet again incorrectly applied the ACPI_NONSTRING
attribute where it is not needed.
A warning was initially reported by Collin Funk [1], and further review
by Jiri Slaby [2] highlighted another issue related to the same commit.
Drop the ACPI_NONSTRING attribute to fix the issue.
Fixes: 70662db73d54 ("ACPICA: Apply ACPI_NONSTRING in more places")
Link: https://lore.kernel.org/all/87ecvpcypw.fsf@gmail.com [1]
Link: https://lore.kernel.org/all/5c210121-c9b8-4458-b1ad-0da24732ac72@kernel.org [2]
Link: https://github.com/acpica/acpica/commit/4623b336
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Ahmed Salem <x0rw3ll@gmail.com>
Cc: 6.16+ <stable@vger.kernel.org> # 6.16+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/acpica/acdebug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/acdebug.h b/drivers/acpi/acpica/acdebug.h
index fe6d38b43c9a..91241bd6917a 100644
--- a/drivers/acpi/acpica/acdebug.h
+++ b/drivers/acpi/acpica/acdebug.h
@@ -37,7 +37,7 @@ struct acpi_db_argument_info {
struct acpi_db_execute_walk {
u32 count;
u32 max_count;
- char name_seg[ACPI_NAMESEG_SIZE + 1] ACPI_NONSTRING;
+ char name_seg[ACPI_NAMESEG_SIZE + 1];
};
#define PARAM_LIST(pl) pl
--
2.51.0
next prev parent reply other threads:[~2025-09-12 20:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 19:51 [PATCH v1 00/16] ACPICA: ACPICA 20250807 Rafael J. Wysocki
2025-09-12 19:52 ` [PATCH v1 01/16] ACPICA: Modify variable definition position Rafael J. Wysocki
2025-09-12 19:53 ` [PATCH v1 02/16] ACPICA: Remove redundant "#ifdef" definitions Rafael J. Wysocki
2025-09-12 19:54 ` [PATCH v1 03/16] ACPICA: Change the compilation conditions Rafael J. Wysocki
2025-09-12 19:54 ` [PATCH v1 04/16] ACPICA: Allow to skip Global Lock initialization Rafael J. Wysocki
2025-09-12 19:55 ` [PATCH v1 05/16] ACPICA: Apply ACPI_NONSTRING Rafael J. Wysocki
2025-09-12 19:56 ` [PATCH v1 06/16] ACPICA: iASL: Fix printing CDAT table header Rafael J. Wysocki
2025-09-12 19:58 ` [PATCH v1 07/16] ACPICA: acpidump: drop ACPI_NONSTRING attribute from file_name Rafael J. Wysocki
2025-09-12 19:59 ` Rafael J. Wysocki [this message]
2025-09-12 20:00 ` [PATCH v1 09/16] ACPICA: dispatcher: Use acpi_ds_clear_operands() in acpi_ds_call_control_method() Rafael J. Wysocki
2025-09-12 20:01 ` [PATCH v1 10/16] ACPICA: Update dsmethod.c to get rid of unused variable warning Rafael J. Wysocki
2025-09-12 20:01 ` [PATCH v1 11/16] ACPICA: Print error messages for too few or too many arguments Rafael J. Wysocki
2025-09-12 20:02 ` [PATCH v1 12/16] ACPICA: Update version to 20250807 Rafael J. Wysocki
2025-09-12 20:03 ` [PATCH v1 13/16] ACPICA: Fix largest possible resource descriptor index Rafael J. Wysocki
2025-09-12 20:04 ` [PATCH v1 14/16] ACPICA: CEDT: Add Back-Invalidate restriction to CXL Window Rafael J. Wysocki
2025-09-12 20:05 ` [PATCH v1 15/16] ACPICA: ACPI_TYPE_ANY does not include the package type Rafael J. Wysocki
2025-09-12 20:06 ` [PATCH v1 16/16] ACPICA: acpidump: fix return values in ap_is_valid_checksum() Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2252228.Mh6RI2rZIc@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saket.dumbre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox