From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [resend PATCH 1/3] ACPI / platform: provide default DMA mask Date: Wed, 24 Sep 2014 15:49:40 +0200 Message-ID: <2261149.pJ2DW810R9@vostro.rjw.lan> References: <1411545639-18741-1-git-send-email-heikki.krogerus@linux.intel.com> <1411545639-18741-2-git-send-email-heikki.krogerus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1411545639-18741-2-git-send-email-heikki.krogerus@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Heikki Krogerus Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Wednesday, September 24, 2014 11:00:37 AM Heikki Krogerus wrote: > Most devices are configured for 32-bit DMA addresses. > Setting the mask to 32-bit here removes the need for the > drivers to do it separately. > > Signed-off-by: Heikki Krogerus > Cc: "Rafael J. Wysocki" ACK > --- > drivers/acpi/acpi_platform.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > index 2bf9082..8d099e6 100644 > --- a/drivers/acpi/acpi_platform.c > +++ b/drivers/acpi/acpi_platform.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > > #include "internal.h" > @@ -102,6 +103,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev) > pdevinfo.res = resources; > pdevinfo.num_res = count; > pdevinfo.acpi_node.companion = adev; > + pdevinfo.dma_mask = DMA_BIT_MASK(32); > pdev = platform_device_register_full(&pdevinfo); > if (IS_ERR(pdev)) > dev_err(&adev->dev, "platform device creation failed: %ld\n", > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.