From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: sudeep.holla@arm.com, gregkh@linuxfoundation.org,
linux-acpi@vger.kernel.org, jeremy.linton@arm.com,
linux-kernel@vger.kernel.org, vkilari@codeaurora.org
Subject: Re: [PATCH v4 0/2] PPTT handle Handle architecturally unknown cache types
Date: Fri, 05 Oct 2018 11:45:34 +0200 [thread overview]
Message-ID: <2264331.PzHIdRIQff@aspire.rjw.lan> (raw)
In-Reply-To: <1538666406-7504-1-git-send-email-jhugo@codeaurora.org>
On Thursday, October 4, 2018 5:20:04 PM CEST Jeffrey Hugo wrote:
> The ARM Architecture Reference Manual allows for caches to be "invisible" and
> thus not specified in the system registers under some scenarios such as if the
> cache cannot be managed by set/way operations.
>
> However, such caches may be specified in the ACPI PPTT table for workload
> performance/scheduling optimizations.
>
> Currently such caches can cause an error in lscpu -
>
> lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such
> file or directory
>
> and result in no output, providing a poor user experience. lstopo is also
> affected as such caches are not included in the output.
>
> Address these issues by attempting to be a little more discerning about when
> cache information is provided to userspace, and also utilize all sources for
> cache information when possible.
>
> [v4]
> -Collected all current tags and ammended to individual patches
> -Removed PPTT_CHECKED_ATTRIBUTES
>
> [v3]
> -removed valid flag in PPTT
> -Added Jeremy Linton's reviewed-by
>
> [v2]
> -Updated cacheinfo per Sudeep's suggestion
> -Integrated the PPTT fix into existing PPTT code per Sudeep's suggestion
>
> Jeffrey Hugo (2):
> drivers: base: cacheinfo: Do not populate sysfs for unknown cache
> types
> ACPI/PPTT: Handle architecturally unknown cache types
>
> drivers/acpi/pptt.c | 15 +++++++++++----
> drivers/base/cacheinfo.c | 2 ++
> 2 files changed, 13 insertions(+), 4 deletions(-)
>
>
Both patches applied, thanks!
prev parent reply other threads:[~2018-10-05 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 15:20 [PATCH v4 0/2] PPTT handle Handle architecturally unknown cache types Jeffrey Hugo
2018-10-04 15:20 ` [PATCH v4 1/2] drivers: base: cacheinfo: Do not populate sysfs for " Jeffrey Hugo
2018-10-04 15:41 ` Greg KH
2018-10-04 15:20 ` [PATCH v4 2/2] ACPI/PPTT: Handle architecturally " Jeffrey Hugo
2018-10-05 9:45 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2264331.PzHIdRIQff@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.linton@arm.com \
--cc=jhugo@codeaurora.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vkilari@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).