From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Aaron Lu <aaron.lwe@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Len Brown <lenb@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH 1/3] acpi: video: trivial costmetic cleanups
Date: Fri, 02 Aug 2013 16:05:17 +0200 [thread overview]
Message-ID: <2368382.8sxrvVTxSB@vostro.rjw.lan> (raw)
In-Reply-To: <CAMP44s0cGyv+2xM1m+qp0oZxjmPGv1-0Me7Afeqmbb6ms=rFHQ@mail.gmail.com>
On Thursday, August 01, 2013 11:15:38 PM Felipe Contreras wrote:
> On Thu, Aug 1, 2013 at 8:50 PM, Aaron Lu <aaron.lwe@gmail.com> wrote:
> > On 08/02/2013 07:43 AM, Felipe Contreras wrote:
> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > Please add change log explaining what you have changed.
> > It seems that the patch modify comment style only, some add a space and
> > some change spaces to tab, is it the case?
>
> The commit message already explains what the change is; trivial
> cosmetic cleanups. Cosmetic means it's completely superficial.
And I have a rule not to apply patches without changelogs. So either I'll
need to write it for you, or can you add one pretty please?
Rafael
next prev parent reply other threads:[~2013-08-02 13:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 23:43 [PATCH 0/3] acpi: video: trivial cleanups Felipe Contreras
2013-08-01 23:43 ` [PATCH 1/3] acpi: video: trivial costmetic cleanups Felipe Contreras
2013-08-02 1:50 ` Aaron Lu
2013-08-02 4:15 ` Felipe Contreras
2013-08-02 14:05 ` Rafael J. Wysocki [this message]
2013-08-02 17:52 ` Felipe Contreras
2013-08-03 0:07 ` Rafael J. Wysocki
2013-08-03 1:34 ` Felipe Contreras
2013-08-03 11:38 ` Rafael J. Wysocki
2013-08-03 20:28 ` Felipe Contreras
2013-08-01 23:44 ` [PATCH 2/3] acpi: video: trivial style cleanups Felipe Contreras
2013-08-02 1:55 ` Aaron Lu
2013-08-02 4:18 ` Felipe Contreras
2013-08-02 14:09 ` Rafael J. Wysocki
2013-08-02 17:56 ` Felipe Contreras
2013-08-03 0:01 ` Rafael J. Wysocki
2013-08-03 1:28 ` Felipe Contreras
2013-08-01 23:44 ` [PATCH 3/3] acpi: video: remove unnecessary casting Felipe Contreras
2013-08-02 1:58 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2368382.8sxrvVTxSB@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=aaron.lwe@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).