From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-fbdev@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-pm@vger.kernel.org, srinivas.pandruvada@intel.com
Subject: Re: [PATCH v2 0/3] Support INT3406 Display thermal device
Date: Tue, 26 Apr 2016 02:58:41 +0200 [thread overview]
Message-ID: <2383528.7J2tIpIfEZ@vostro.rjw.lan> (raw)
In-Reply-To: <1460532771-22779-1-git-send-email-aaron.lu@intel.com>
On Wednesday, April 13, 2016 03:32:48 PM Aaron Lu wrote:
> The display thermal device represents the LED/LCD display panel
> that may or may not include touch support. The main function of
> the display thermal device is to allow control of the display
> brightness in order to address a thermal condition or to reduce
> power consumed by display device.
>
> Due to the way this thermal device changes brightness level is said
> to be deprecated so we are using the raw interface to do the actual
> backlight change. This requires the backlight core support so two
> new APIs are added and exported in patch 1/3. With this, the previous
> API backlight_device_registered can be removed and this is done in
> patch 2/3. Patch 3/3 adds the new int3406 thermal driver.
>
> The 1st version is here:
> http://thread.gmane.org/gmane.linux.acpi.devel/72619
>
> This whole series should go through the thermal tree if applied.
>
> Aaron Lu (3):
> video / backlight: add two APIs for drivers to use
> video / backlight: remove the backlight_device_registered API
> Thermal: add INT3406 thermal driver
So I have nothing against [1-2/3], but the [3/3] tries to do too many things
in one go. It should be at least two separate patches to my eyes, one making
changes to the ACPI video driver and the other adding the INT3406 one.
Thanks,
Rafael
next prev parent reply other threads:[~2016-04-26 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 7:32 [PATCH v2 0/3] Support INT3406 Display thermal device Aaron Lu
2016-04-13 7:32 ` [PATCH 1/3] video / backlight: add two APIs for drivers to use Aaron Lu
2016-04-13 7:32 ` [PATCH 2/3] video / backlight: remove the backlight_device_registered API Aaron Lu
2016-04-13 7:32 ` [PATCH 3/3] Thermal: add INT3406 thermal driver Aaron Lu
2016-04-26 0:58 ` Rafael J. Wysocki [this message]
2016-04-26 7:33 ` [PATCH v2 0/3] Support INT3406 Display thermal device Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2383528.7J2tIpIfEZ@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=aaron.lu@intel.com \
--cc=jingoohan1@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox