From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB48C76191 for ; Thu, 18 Jul 2019 08:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CEAD208C0 for ; Thu, 18 Jul 2019 08:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726395AbfGRInK (ORCPT ); Thu, 18 Jul 2019 04:43:10 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:58640 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbfGRInJ (ORCPT ); Thu, 18 Jul 2019 04:43:09 -0400 Received: from 79.184.255.39.ipv4.supernova.orange.pl (79.184.255.39) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.267) id 9a5cff5b74e7777b; Thu, 18 Jul 2019 10:43:07 +0200 From: "Rafael J. Wysocki" To: Erik Schmauss Cc: linux-acpi@vger.kernel.org, Bob Moore Subject: Re: [PATCH v2 1/2] ACPICA: Update table load object initialization Date: Thu, 18 Jul 2019 10:43:07 +0200 Message-ID: <2383721.89ovj2a0fz@kreacher> In-Reply-To: <20190711165821.16372-1-erik.schmauss@intel.com> References: <20190711165821.16372-1-erik.schmauss@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thursday, July 11, 2019 6:58:21 PM CEST Erik Schmauss wrote: > ACPICA commit c7ef9f3526765bed8930825dda1eed1a274b9668 > > Use the common internal "initialize objects" interface > Affects: > Load() > load_table() > acpi_load_table > > Link: https://github.com/acpica/acpica/commit/c7ef9f35 > > Tested-by: Rong Chen > Signed-off-by: Bob Moore > Signed-off-by: Erik Schmauss > --- > drivers/acpi/acpica/exconfig.c | 18 ++++++++---------- > drivers/acpi/acpica/tbxfload.c | 10 +++------- > 2 files changed, 11 insertions(+), 17 deletions(-) > > diff --git a/drivers/acpi/acpica/exconfig.c b/drivers/acpi/acpica/exconfig.c > index 587aeeeb5070..46a8baf28bd0 100644 > --- a/drivers/acpi/acpica/exconfig.c > +++ b/drivers/acpi/acpica/exconfig.c > @@ -174,12 +174,11 @@ acpi_ex_load_table_op(struct acpi_walk_state *walk_state, > return_ACPI_STATUS(status); > } > > - /* Complete the initialization/resolution of package objects */ > + /* Complete the initialization/resolution of new objects */ > > - status = acpi_ns_walk_namespace(ACPI_TYPE_PACKAGE, ACPI_ROOT_OBJECT, > - ACPI_UINT32_MAX, 0, > - acpi_ns_init_one_package, NULL, NULL, > - NULL); > + acpi_ex_exit_interpreter(); > + acpi_ns_initialize_objects(); > + acpi_ex_enter_interpreter(); > > /* Parameter Data (optional) */ > > @@ -437,12 +436,11 @@ acpi_ex_load_op(union acpi_operand_object *obj_desc, > return_ACPI_STATUS(status); > } > > - /* Complete the initialization/resolution of package objects */ > + /* Complete the initialization/resolution of new objects */ > > - status = acpi_ns_walk_namespace(ACPI_TYPE_PACKAGE, ACPI_ROOT_OBJECT, > - ACPI_UINT32_MAX, 0, > - acpi_ns_init_one_package, NULL, NULL, > - NULL); > + acpi_ex_exit_interpreter(); > + acpi_ns_initialize_objects(); > + acpi_ex_enter_interpreter(); > > /* Store the ddb_handle into the Target operand */ > > diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c > index ef8f8a9f3c9c..86f1693f6d29 100644 > --- a/drivers/acpi/acpica/tbxfload.c > +++ b/drivers/acpi/acpica/tbxfload.c > @@ -297,15 +297,11 @@ acpi_status acpi_load_table(struct acpi_table_header *table) > status = acpi_tb_install_and_load_table(ACPI_PTR_TO_PHYSADDR(table), > ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL, > FALSE, &table_index); > - > if (ACPI_SUCCESS(status)) { > - /* Complete the initialization/resolution of package objects */ > > - status = acpi_ns_walk_namespace(ACPI_TYPE_PACKAGE, > - ACPI_ROOT_OBJECT, > - ACPI_UINT32_MAX, 0, > - acpi_ns_init_one_package, > - NULL, NULL, NULL); > + /* Complete the initialization/resolution of new objects */ > + > + acpi_ns_initialize_objects(); > } > > return_ACPI_STATUS(status); > Applied, thanks!