From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: andreas.noever@gmail.com, matthew.garrett@nebula.com
Cc: lenb@kernel.org, robert.moore@intel.com, lv.zheng@intel.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.or,
linux-pci@vger.kernel.org, bhelgaas@google.com,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH v2 0/3] ACPI: Improve behaviour on Apple hardware
Date: Sun, 21 Sep 2014 02:22:42 +0200 [thread overview]
Message-ID: <2602701.nnkzbmBANY@vostro.rjw.lan> (raw)
In-Reply-To: <cover.1411211725.git.andreas.noever@gmail.com>
On Saturday, September 20, 2014 01:19:44 PM andreas.noever@gmail.com wrote:
> From: Andreas Noever <andreas.noever@gmail.com>
>
> This is a resend of Matthew's patches from https://lkml.org/lkml/2014/6/1/165
> which are needed to fully support Thunderbolt on Apple hardware:
> > Apple hardware behaves differently depending on whether or not the OS claims
> > to be Darwin. Failing to report Darwin results in some hardware being
> > disabled. However, claiming to be Darwin also alters the behaviour of
> > battery reporting and PCI handling. These patches add support for reporting
> > Darwin support and fixing up the behavioural quirks that are exposed as a
> > result.
> Without these patches the firmware will cut power to the controller after
> suspend (at the latest) and the thunderbolt driver will fail.
>
> I have reordered them such that the two battery fixes/quirks come before the
> _OSI change that breaks battery reporting. I have also merged "ACPI: Don't call
> PCI OSC on Apple hardware when claiming to be Darwin" into "ACPI: Support
> _OSI("Darwin") correctly" to avoid (temporarily) breaking hotplug events and
> modified the patch to not touch ACPICA, as requested by Rafael.
This looks good to me, but I'd like Matthew to say a word here.
Mattew, is this fine by you?
Rafael
next prev parent reply other threads:[~2014-09-21 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 11:19 [PATCH v2 0/3] ACPI: Improve behaviour on Apple hardware andreas.noever
2014-09-20 11:19 ` [PATCH v2 1/3] ACPI: Don't assume the existence of an SBS charger andreas.noever
2014-09-20 11:19 ` [PATCH v2 2/3] ACPI: Disable smart battery manager on Apple andreas.noever
2014-09-20 11:19 ` [PATCH v2 3/3] ACPI: Support _OSI("Darwin") correctly andreas.noever
2014-09-21 0:22 ` Rafael J. Wysocki [this message]
2014-09-25 23:45 ` [PATCH v2 0/3] ACPI: Improve behaviour on Apple hardware Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2602701.nnkzbmBANY@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.or \
--cc=linux-pci@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=matthew.garrett@nebula.com \
--cc=mjg59@srcf.ucam.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox